8000 fix: drop support for outdated operating systems by ltalirz · Pull Request #117 · dokku/ansible-dokku · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: drop support for outdated operating systems #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 9, 2021
Merged

fix: drop support for outdated operating systems #117

merged 3 commits into from
Nov 9, 2021

Conversation

ltalirz
Copy link
Member
@ltalirz ltalirz commented Oct 2, 2021 •
edited
Loading

On Ubuntu 16.04 the nginxinc.nginx roles fails with

The repository 'https://nginx.org/packages/mainline/ubuntu xenial Release' does not have a Release file.

Seems like it's time to drop support; same for Debian 9.

Fixes #123 since all checks will be working again.

@ltalirz
fix: drop support for outdated operating systems
33242e2 
On Ubuntu 16.04 the nginxinc.nginx roles fails with

  The repository 'https://nginx.org/packages/mainline/ubuntu xenial Release' does not have a Release file.

Seems like it's time to drop support; same for Debian 9.
@ltalirz
Copy link
Member Author
ltalirz commented Oct 2, 2021

@josegonzalez This reduces the list of supported operating systems to the ones that we test here.
Just checking you agree with this.

@josegonzalez
Copy link
Member

Isn't Debian 9 Stable or something? I'm happy to drop upstream in the next release if we have good reasoning we can document :)

@ltalirz
Copy link
Member Author
ltalirz commented Oct 3, 2021

Well, it seems the nginx repository has dropped it (just like ubuntu 16.04)

  TASK [nginxinc.nginx : (Debian/Ubuntu) Configure NGINX repository] *************
  failed: [instance] (item=deb [arch=amd64] https://nginx.org/packages/mainline/debian/ stretch nginx) => {"ansible_loop_var": "item", "changed": false, "item": "deb [arch=amd64] https://nginx.org/packages/mainline/debian/ stretch nginx", "msg": "Failed to update apt cache: E:The repository 'https://nginx.org/packages/mainline/debian stretch Release' does not have a Release file."}
  failed: [instance] (item=deb-src https://nginx.org/packages/mainline/debian/ stretch nginx) => {"ansible_loop_var": "item", "changed": false, "item": "deb-src https://nginx.org/packages/mainline/debian/ stretch nginx", "msg": "Failed to update apt cache: E:The repository 'https://nginx.org/packages/mainline/debian stretch Release' does not have a Release file."}

@josegonzalez
Copy link
Member

Can we conditionally include that recipe? I think nginx from the official repos is new enough for dokku now.

@ltalirz
Copy link
Member Author
ltalirz commented Nov 7, 2021

Can we conditionally include that recipe? I think nginx from the official repos is new enough for dokku now.

Can you elaborate a bit on what you're suggesting here?
Should we have different code paths for the debian installation depending on the debian version?
Or drop the geerlingguy.nginx role for a "manual" installation of nginx altogether?

@josegonzalez
Copy link
Member

Drop geerlingguy.nginx and just install nginx normally. It's also a dependency of dokku so it gets installed anyways...

@ltalirz
Copy link
Member Author
ltalirz commented Nov 9, 2021

Drop geerlingguy.nginx and just install nginx normally. It's also a dependency of dokku so it gets installed anyways...

Sounds good; will do this in #122

In the meanwhile, I'll merge this with the new CI checks (keeping compatibility in the role back to Ubuntu 16.04 and Debian 9) since the failing checks are preventing pushes to ansible galaxy.

@ltalirz ltalirz merged commit b8c52f2 into dokku:master Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Latest version not available on Ansible Galaxy
2 participants
@ltalirz @josegonzalez
0