8000 chore: remove dokku_ecr by ltalirz · Pull Request #121 · dokku/ansible-dokku · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: remove dokku_ecr #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 9, 2021
Merged

chore: remove dokku_ecr #121

merged 2 commits into from
Nov 9, 2021

Conversation

ltalirz
Copy link
Member
@ltalirz ltalirz commented Nov 7, 2021

fix #119

The source is only available to José at this time, and dokku_registry
should support ecr just fine.

@josegonzalez
Copy link
Member

Probably should also remove dokku-consul and dokku-git-sync. Both are commercial and I have no intention of OSS'ing. The former is better served by registrator, while the latter is now built into Dokku.

The source is only available to José at this time, and `dokku_registry`
should support ecr just fine.
Users are better served by registrator, see

    https://github.com/gliderlabs/registrator
@ltalirz ltalirz force-pushed the issue_19_dokku_ecr branch from 38955c7 to 331cc3a Compare November 9, 2021 09:31
@ltalirz
Copy link
Member Author
ltalirz commented Nov 9, 2021

Probably should also remove dokku-consul and dokku-git-sync. Both are commercial and I have no intention of OSS'ing. The former is better served by registrator, while the latter is now built into Dokku.

Sounds good - I'll remove dokku-consul here; dokku-git-sync will be handled in a separate PR.

@ltalirz ltalirz merged commit cddf335 into master Nov 9, 2021
@josegonzalez josegonzalez deleted the issue_19_dokku_ecr branch November 10, 2021 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dokku_ecr module
2 participants
0