-
-
Notifications
You must be signed in to change notification settings - Fork 23
i18n + fr Locale + Asset Bundles + Standalone #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apparently you had to specify auto as the stat name for it to actually work hahahaha
for Terapagos-Stellar, specifically
particularly for Terapagos, where it has the Tera Shift ability, but don't want that to override the abilities of the other two formes. validation is a no-op in OMs.
by tapping directly into the mainframe in order to disable the algorithms
ubers sets don't run away from the auto-preseter in ubersuu anymore
basically broke the hellodex.focusRoomsRoom setting cause the Hellodex would mount before the settings were restored from IndexedDB. science
sacré bleu
not a fan of i18n's () ... keep typing instead LOL
in buildFormeOptions()
in useCalcdexContext()
didn't realize they renamed it lmaooo
namely Acrobatics + Flying Gem, Return & Frustration
for consistent preset calcdexId's across versions, otherwise the preset dropdown in honks will jarringly say none
mad brilliant commit this one
the Pony Express gives Opera's mod team a run for its money in terms of communication speed lolol no shade just joshin hehe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR largely implements internationalization (aka. i18n) & replaces all the strings in the UI into JSON files split by locale. In addition, a new asset bundle loading system for bundling sets into Showdex builds was kinda added not really it's just a fancy way of saying I wrote TypeScript interfaces (but it looks cool) lmao. Finally, a new experimental
'standalone'
BUILD_TARGET
was implemented.Oh ya, the bugs. Fixed ! c:
See the v1.2.1 release for more detailed information regarding the changes made in this PR.
Issues
Closes #177
Closes #178