Fix fetching git history + fallback to unshallow repo #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For most situation it should be enough to find merge base. Previous value was too slow and overhead of doing fetch was significantly higher than saving of transfer.
micgro42
added a commit
to wmde/wikit
that referenced
this pull request
Mar 9, 2021
The latest release of the paths-filter action 2.9.1 caused a failure of all CI update jobs. This release contained a single PR dorny/paths-filter#74 The error message in all of our CI setup jobs was: Run dorny/paths-filter@v2 with: filters: visual: - 'tokens/**' - 'vue-components/**' behavioral: - 'vue-components/**' token: *** list-files: none initial-fetch-depth: 100 Changes will be detected against the branch master Searching for merge-base master...QuantityInput /usr/bin/git rev-list --count --all 640 /usr/bin/git merge-base master QuantityInput fatal: Not a valid object name master /usr/bin/git fetch --depth=1280 origin master:master QuantityInput From wmde/wikit * [new branch] master -> master * branch QuantityInput -> FETCH_HEAD /usr/bin/git rev-list --count --all 640 No more commits were fetched Last attempt will be to fetch full history /usr/bin/git fetch --unshallow fatal: --unshallow on a complete repository does not make sense Error: The process '/usr/bin/git' failed with exit code 128
|
This PR caused our CI to consistently fail. Going back to 2.9.0 resolved the issue. The error message in the logs: |
|
Thanks for reporting the issue. I rolled back |
|
I think I know what happened. I will fix it soon |
Ladsgroup
pushed a commit
to wmde/wikit
that referenced
this pull request
Mar 9, 2021
The latest release of the paths-filter action 2.9.1 caused a failure of all CI update jobs. This release contained a single PR dorny/paths-filter#74 The error message in all of our CI setup jobs was: Run dorny/paths-filter@v2 with: filters: visual: - 'tokens/**' - 'vue-components/**' behavioral: - 'vue-components/**' token: *** list-files: none initial-fetch-depth: 100 Changes will be detected against the branch master Searching for merge-base master...QuantityInput /usr/bin/git rev-list --count --all 640 /usr/bin/git merge-base master QuantityInput fatal: Not a valid object name master /usr/bin/git fetch --depth=1280 origin master:master QuantityInput From wmde/wikit * [new branch] master -> master * branch QuantityInput -> FETCH_HEAD /usr/bin/git rev-list --count --all 640 No more commits were fetched Last attempt will be to fetch full history /usr/bin/git fetch --unshallow fatal: --unshallow on a complete repository does not make sense Error: The process '/usr/bin/git' failed with exit code 128
|
@micgro42 |
|
Thank you for the quick fix 🙏 |
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetching git history did not worked in all cases.
As described in #71 - either deepening the history or counting the commits didn't worked as expected.
This PR uses combination of
--depthon initial fetch and later--deepenis used to extend historyCommits are now counted on all branches
git rev-list --count --all.It also increases default value of initial-fetch-depth to 100.
For most cases it should only do a single fetch.
As a last fallback try - whole history is fetched by turning shallow repo into full clone using
git fetch --unshallowcloses #71