8000 Actor-Signal Interface by marvin-steinke · Pull Request #211 · dos-group/vessim · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Actor-Signal Interface 8000 #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Jun 21, 2024
Merged

Actor-Signal Interface #211

merged 22 commits into from
Jun 21, 2024

Conversation

marvin-steinke
Copy link
Contributor
@marvin-steinke marvin-steinke commented May 26, 2024 •
edited
Loading

Signals

  • HistoricalSignal now has a a default column so the code from the paper works, also looks better
  • HistoricalSignal.from_dataset() renamed to load()
  • Signal ABC has some more boilerplate code, including a name; at(self, dt: DatetimeLike, **kwargs) function is changed to now(self, at: Optional[DatetimeLike] = None, **kwargs) and returns a float.

Power Meters

  • removed PowerMeter ABC as its basically just a signal now
  • MockPowerMeter is now MockSignal and resides in signal.py as it is now a child of Signal

Actors

  • Actor is no longer an ABC
  • Actor in combination with a signal now behaves similiar to a Generator
  • ActorBase is the new ABC and parent of Actor and ComputingSystem and to used for custom Actor implementations
  • kwargs arg is no longer needed, right?
  • removed Generator class
  • ComputingSystem now takes multiple signals instead of power meters and names them in case they are not

@marvin-steinke marvin-steinke requested a review from kilianp14 May 26, 2024 06:30
kilianp14
kilianp14 reviewed May 27, 2024
View reviewed changes
kilianp14
kilianp14 reviewed May 27, 2024
View reviewed changes
kilianp14
kilianp14 reviewed May 27, 2024
View reviewed changes
kilianp14
kilianp14 8000 reviewed May 27, 2024
View reviewed changes
kilianp14
kilianp14 reviewed Jun 3, 2024
View reviewed changes
@marvin-steinke marvin-steinke mentioned this pull request Jun 18, 2024
Closed
@marvin-steinke marvin-steinke marked this pull request as ready for review June 18, 2024 13:50
kilianp14
kilianp14 approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor
@kilianp14 kilianp14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good to me :)

@marvin-steinke marvin-steinke merged commit 3497395 into main Jun 21, 2024
4 checks passed
@marvin-steinke marvin-steinke deleted the actor_interface branch June 21, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilianp14 kilianp14 kilianp14 approved these changes

@birnbaum birnbaum Awaiting requested review from birnbaum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marvin-steinke @kilianp14
0