8000 Adds trigger for disabled state for Thumb by siagupta0202 · Pull Request #10795 · dotnet/wpf · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Adds trigger for disabled state for Thumb #10795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

siagupta0202
Copy link
Contributor
@siagupta0202 siagupta0202 commented Apr 22, 2025

Fixes #10497

Description

Adds a trigger to change the Background color in the Disabled state for Thumb

Customer Impact

No visual feedback for disabled state for Thumb

Regression

Testing

local build pass

Risk

Low

Microsoft Reviewers: Open in CodeFlow

@Copilot Copilot AI review requested due to automatic review settings April 22, 2025 06:54
@siagupta0202 siagupta0202 requested review from a team as code owners April 22, 2025 06:54
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (7)
  • src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Resources/Theme/Dark.xaml: Language not supported
  • src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Resources/Theme/HC.xaml: Language not supported
  • src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Resources/Theme/Light.xaml: Language not supported
  • src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/Thumb.xaml: Language not supported
  • src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Themes/Fluent.Dark.xaml: Language not supported
  • src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Themes/Fluent.HC.xaml: Language not supported
  • src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Themes/Fluent.Light.xaml: Language not supported

@siagupta0202 siagupta0202 changed the title adds trigger for disabled state for Thumb Adds trigger for disabled state for Thumb Apr 22, 2025
@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label Apr 22, 2025
@siagupta0202 siagupta0202 added this to the 10.0.0 milestone Apr 22, 2025
@siagupta0202 siagupta0202 moved this to 🏗 In Progress in WPF Fluent Theming Apr 22, 2025
Copy link
codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.56018%. Comparing base (052bfc5) to head (c303649).
Report is 2 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #10795         +/-   ##
===================================================
+ Coverage   13.47033%   13.56018%   +0.08985%     
===================================================
  Files           3317        3317                 
  Lines         665596      665596                 
  Branches       74679       74679                 
===================================================
+ Hits           89658       90256        +598     
+ Misses        573333      572646        -687     
- Partials        2605        2694         +89     
Flag Coverage Δ
Debug 13.56018% <ø> (+0.08985%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dipeshmsft dipeshmsft merged commit 96d0050 into dotnet:main Apr 22, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ☑ Done in WPF Fluent Theming Apr 22, 2025
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR metadata: Label to tag PRs, to facilitate with triage Win 11 Theming
Projects
Status: ☑ Done
Development

Successfully merging this pull request may close these issues.

[ Fluent ] Fix Thumb style
2 participants
0