8000 [main] Source code updates from dotnet/dotnet by dotnet-maestro[bot] · Pull Request #10810 · dotnet/wpf · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[main] Source code updates from dotnet/dotnet #10810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 25, 2025
Merged

[main] Source code updates from dotnet/dotnet #10810

merged 8 commits into from
Apr 25, 2025

Conversation

dotnet-maestro[bot]
Copy link
Contributor
@dotnet-maestro dotnet-maestro bot commented Apr 25, 2025 •
edited by dotnet-policy-service bot
Loading

Note

This is a codeflow update. It may contain both source code changes from the VMR as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/dotnet

Updated Dependencies

Microsoft Reviewers: Open in CodeFlow

@dotnet-maestro dotnet-maestro bot requested review from a team as code owners April 25, 2025 02:07
dotnet-policy-service[bot]
dotnet-policy-service bot previously approved these changes Apr 25, 2025
View reviewed changes
Copy link
Contributor
@dotnet-policy-service dotnet-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go, you big red fire engine!

@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label Apr 25, 2025
@ViktorHofer
Address Roslyn analyzer warnings
da68ea0 
IDE0031 and others

These are showing up when building with a P4 .NET 10 SDK. This allows us to remove the warnAsError=false flag in the VMR when building wpf
@ViktorHofer ViktorHofer mentioned this pull request Apr 25, 2025
Closed
@codecov Codecov
Copy link
codecov bot commented Apr 25, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 4.87805% with 39 lines in your changes missing coverage. Please review.

Project coverage is 13.42499%. Comparing base (ea0a13d) to head (ac7ece4).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##                main      #10810         +/-   ##
===================================================
+ Coverage   13.42315%   13.42499%   +0.00183%     
===================================================
  Files           3317        3316          -1     
  Lines         665537      665334        -203     
  Branches       74666       74655         -11     
===================================================
- Hits           89336       89321         -15     
+ Misses        573607      573419        -188     
  Partials        2594        2594
Flag Coverage Δ
Debug 13.42499% <4.87805%> (+0.00183%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dotnet-maestro dotnet-maestro bot merged commit 90cfb1a into main Apr 25, 2025
13 checks passed
@dotnet-maestro dotnet-maestro bot deleted the darc-main-bae88f63-c9cc-4d0e-bbc1-d3bb8ed8a2f5 branch April 25, 2025 07:12
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

@dotnet-policy-service dotnet-policy-service[bot] dotnet-policy-service[bot] left review comments

@dipeshmsft dipeshmsft Awaiting requested review from dipeshmsft

@singhashish-wpf singhashish-wpf Awaiting requested review from singhashish-wpf

@Kuldeep-MS Kuldeep-MS Awaiting requested review from Kuldeep-MS

Assignees
No one assigned
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akoeplinger @ViktorHofer
0