8000 [release/3.1] Centralize VersionPrefix information in Version.props by vatsan-madhavan · Pull Request #2439 · dotnet/wpf · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[release/3.1] Centralize VersionPrefix information in Version.props #2439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2020
Merged

[release/3.1] Centralize VersionPrefix information in Version.props #2439

merged 1 commit into from
Jan 16, 2020

Conversation

vatsan-madhavan
Copy link
Member
@vatsan-madhavan vatsan-madhavan commented Jan 16, 2020 •
edited
Loading

Centralize VersionPrefix information in Version.props

Verified using local build using shipping-versions that this works as intended.

build -ci -pack /p:DotNetUseShippingVersions=true

> dir /s artifacts\packages\Debug\NonShipping\ /b 

C:\src\repos\wpf\artifacts\packages\Debug\NonShipping\Microsoft.DotNet.Arcade.Wpf.Sdk.4.8.1-ci.20065.1.nupkg
C:\src\repos\wpf\artifacts\packages\Debug\NonShipping\Microsoft.DotNet.Wpf.GitHub.4.8.1-ci.20065.1.nupkg
C:\src\repos\wpf\artifacts\packages\Debug\NonShipping\Microsoft.DotNet.Wpf.ProjectTemplates.3.1.2-ci.20065.1.nupkg
C:\src\repos\wpf\artifacts\packages\Debug\NonShipping\Microsoft.NET.Sdk.WindowsDesktop.3.1.2-ci.20065.1.nupkg
C:\src\repos\wpf\artifacts\packages\Debug\NonShipping\runtime.win-x86.Microsoft.DotNet.Wpf.GitHub.4.8.1-ci.20065.1.nupkg

/cc @mmitche, thoughts about taking this in ?

@ghost ghost requested a review from rladuca January 16, 2020 01:44
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Jan 16, 2020
@ghost ghost requested a review from SamBent January 16, 2020 01:44
@vatsan-madhavan vatsan-madhavan added the tell-mode Issues and PR's that require notice to .NET Core Shiproom label Jan 16, 2020
@vatsan-madhavan vatsan-madhavan merged commit 589ace3 into dotnet:release/3.1 Jan 16, 2020
@vatsan-madhavan vatsan-madhavan deleted the refactor-versionprefix-rel31 branch January 16, 2020 17:47
@vatsan-madhavan vatsan-madhavan mentioned this pull request Mar 5, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Apr 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmitche mmitche mmitche approved these changes

@rladuca rladuca Awaiting requested review from rladuca

@SamBent SamBent Awaiting requested review from SamBent

Assignees
No one assigned
Labels
PR metadata: Label to tag PRs, to facilitate with triage tell-mode Issues and PR's that require notice to .NET Core Shiproom
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vatsan-madhavan @mmitche
0