Adding Iot.Device.Bindings package #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshfree
reviewed
Jan 24, 2019
| <MinorVersion>1</MinorVersion> | ||
| <Description>This preview package provides a set of Device Bindings that use System.Device.Gpio package to communicate with a microcontroller.</Description> | ||
| <Copyright>Microsoft Corporation, All rights reserved.</Copyright> | ||
| <PackageTags>.NET Core GPIO Pins SPI I2C PWM BCM2835 RPi IoT Device Bindings</PackageTags> |
There was a problem hiding this comment.
this should be BCM2837 i believe (or should be added to the list)
joshfree
reviewed
Jan 24, 2019
| @@ -33,27 +33,27 @@ Mcp3008 GetMcp3008WithSpi() | |||
| }; | |||
|
|
|||
| var spi = new UnixSpiDevice(connection); | |||
| var mcp3008 = new Mcp3008(spi); | |||
| var mcp3008 = new Mcp3008.Mcp3008(spi); | |||
| return mcp3008; | |||
| } | |||
|
|
|||
| // GPIO (via bit banging) implementation | |||
There was a problem hiding this comment.
just a note on this comment, isn't this using HW SPI support underneath (not software SPI, ie bit banging)
joshfree
approved these changes
Jan 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @richlander @joshfree
Adding Device Bindings package so that it gets produced as part of the build.