8000 [bgen] Don't emit/use [Preserve] attributes anymore. Fixes #19524. by rolfbjarne · Pull Request #22860 · dotnet/macios · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[bgen] Don't emit/use [Preserve] attributes anymore. Fixes #19524. #22860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

[bgen] Don't emit/use [Preserve] attributes anymore. Fixes #19524. #22860

wants to merge 13 commits into from

Conversation

rolfbjarne
Copy link
Member

Fixes #19524.

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
dalexsoto
dalexsoto reviewed May 21, 2025
View reviewed changes
src/bgen/Generator.cs
@@ -5330,6 +5325,9 @@ public void PrintPreserveAttribute (ICustomAttributeProvider mi)
if (p is null)
return;

if (!BindThirdPartyLibrary)
throw new InvalidOperationException ($"Found [Preserve] on {FormatProvider (mi)}: [Preserve] is deprecated, so don't use it.");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe point to the new way of doing this here?

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #5d0b19b] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 5d0b19b4f20776b6710294bafabaf5c8dd32d8e4 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #5d0b19b] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 5d0b19b4f20776b6710294bafabaf5c8dd32d8e4 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 5d0b19b4f20776b6710294bafabaf5c8dd32d8e4 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #5d0b19b] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 5d0b19b4f20776b6710294bafabaf5c8dd32d8e4 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #5d0b19b] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 5d0b19b4f20776b6710294bafabaf5c8dd32d8e4 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #5d0b19b] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 5d0b19b4f20776b6710294bafabaf5c8dd32d8e4 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #5d0b19b] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 5d0b19b4f20776b6710294bafabaf5c8dd32d8e4 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #5d0b19b] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 5d0b19b4f20776b6710294bafabaf5c8dd32d8e4 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build #5d0b19b] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 9 tests failed, 113 tests passed.

Failures

❌ cecil tests

1 tests failed, 0 tests passed.
  • Cecil-based tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ generator tests

1 tests failed, 4 tests passed.
  • BGen tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ monotouch tests (MacCatalyst)

6 tests failed, 9 tests passed.
  • monotouch-test/Mac Catalyst/Release (managed static registrar): Failed (Test run failed.
    Tests run: 3205 Passed: 3022 Inconclusive: 10 Failed: 38 Ignored: 145)
  • monotouch-test/Mac Catalyst/Release (managed static registrar, all optimizations): Failed (Test run failed.
    Tests run: 3205 Passed: 3025 Inconclusive: 9 Failed: 38 Ignored: 142)
  • monotouch-test/Mac Catalyst/Release (static registrar): BuildFailure
  • monotouch-test/Mac Catalyst/Release (static registrar, all optimizations): Failed (Test run failed.
    Tests run: 3205 Passed: 3024 Inconclusive: 10 Failed: 38 Ignored: 143)
  • monotouch-test/Mac Catalyst/Release (ARM64, LLVM): Failed (Test run failed.
    Tests run: 3205 Passed: 3024 Inconclusive: 10 Failed: 38 Ignored: 143)
  • monotouch-test/Mac Catalyst/Release (interpreter): Failed (Test run failed.
    Tests run: 3205 Passed: 3023 Inconclusive: 9 Failed: 38 Ignored: 144)

Html Report (VSDrops) Download

❌ windows tests

1 tests failed, 0 tests passed.

Html Report (VSDrops) Download

Successes

✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 10 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 5d0b19b4f20776b6710294bafabaf5c8dd32d8e4 [PR build]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexsoto dalexsoto dalexsoto left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update bgen to generate DynamicDependency attributes instead of Preserve attributes
3 participants
@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto
0