[pull] main from r-lib:main #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perf: add missing fixed for fixed strings
tests: move to testthat mocking
Skip test that requires rstudioapi
tests: combine consecutive mocking calls
This commit conditions on the presence of rstudioapi 0.17.0. If satisfied then use the new getMode() function (https://github.com/rstudio/rstudioapi/releases/tag/v0.17.0). Otherwise maintain the old behaviour. Printing of a slowish data frame in RStudio improved from ~18 seconds, to ~3 seconds with this commit and rstudioapi v0.17.0.
- fixes a comparison between strings to a comparison between a numeric_version and a string (a valid op). - Uses getNamespaceVersion as clearer and part of base API as well as still being performant.
Fix #621
Add hash_xxhash etc. functions
Nitpicks to get totally clean R CMD check
Add snapshot for current rlang (v1.1.4)
Fix flaky snapshot test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )