fix(multipath): disable user_friendly_names with mpathconf #1306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If dracut is creating /etc/multipath.conf by calling mpathconf in either multipathd-configure.service or multipathd.sh, there is a chance that the multipath config in the real root differs. Specifically, it might have chosen different user_friendly_names for the devices. When the systems switches to the real root, multipath may not be able to switch the devices to their configured names because those might already be in use. To avoid this, call mpathconf with "--user_friendly_names n" to create a multipath.conf with user_friendly_names disabled. If all devices use WWID names, it is always possible for multipath to rename them later. Fixes b8a92b7 ("multipath: add automatic configuration for multipath")
|
CC @mwilck |
|
Ack, or rather non-nack, from my side. mpathconf is RH/Fedora specific, and this PR only touches the mpathconf code path. |
LaszloGombos
approved these changes
Apr 29, 2025
|
LGTM, thanks! |
|
Thanks, overall ack from me, though we'll get this tested on RHCOS and FCOS to be sure. |
Conan-Kudo
approved these changes
Apr 30, 2025
jcapiitao
added a commit
to jcapiitao/fedora-coreos-config
that referenced
this pull request
May 16, 2025
We are awaiting some dracut patches to land in Fedora mirror for [1]. We could wait for it, but we'd need it also for older rhcos branches and those branches won't have the new dracut. So we decided to carry part of the dracut-ng patch [2] in a post-script. This will be backported in older rhcos branches, and will be reverted on testing-devel once new dracut 107 available in mirror. [1] coreos/fedora-coreos-tracker#1937 [2] dracut-ng/dracut-ng#1306
jcapiitao
added a commit
to jcapiitao/fedora-coreos-config
that referenced
this pull request
May 19, 2025
We are awaiting some dracut patches to land in Fedora mirror for [1]. We could wait for it, but we'd need it also for older rhcos branches and those branches won't have the new dracut. So we decided to carry part of the dracut-ng patch [2] in a post-script. This will be backported in older rhcos branches, and will be reverted on testing-devel once new dracut 107 available in mirror. [1] coreos/fedora-coreos-tracker#1937 [2] dracut-ng/dracut-ng#1306
jcapiitao
added a commit
to jcapiitao/fedora-coreos-config
that referenced
this pull request
May 20, 2025
We are awaiting some dracut patches to land in Fedora mirror for [1]. We could wait for it, but we'd need it also for older rhcos branches and those branches won't have the new dracut. So we decided to carry part of the dracut-ng patch [2] in a post-script. This will be backported in older rhcos branches, and will be reverted on testing-devel once new dracut 107 available in mirror. [1] coreos/fedora-coreos-tracker#1937 [2] dracut-ng/dracut-ng#1306
jcapiitao
added a commit
to jcapiitao/fedora-coreos-config
that referenced
this pull request
May 20, 2025
We are awaiting some dracut patches to land in Fedora mirror for [1]. We could wait for it, but we'd need it also for older rhcos branches and those branches won't have the new dracut. So we decided to carry part of the dracut-ng patch [2] in a post-script. This will be backported in older rhcos branches, and will be reverted on testing-devel once new dracut 107 available in mirror. [1] coreos/fedora-coreos-tracker#1937 [2] dracut-ng/dracut-ng#1306
jcapiitao
added a commit
to jcapiitao/fedora-coreos-config
that referenced
this pull request
May 21, 2025
This test can be re-enable as we are applying part of the dracut-ng patch [1] in a postprocess script. This script is a workaround solution while awaiting the bump of dracut RPM NVR including [1] in Fedora, and will be removed afterward. [1] dracut-ng/dracut-ng#1306
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If dracut is creating /etc/multipath.conf by calling mpathconf in either multipathd-configure.service or multipathd.sh, there is a chance that the multipath config in the real root differs. Specifically, it might have chosen different user_friendly_names for the devices. When the systems switches to the real root, multipath may not be able to switch the devices to their configured names because those might already be in use. To avoid this, call mpathconf with "--user_friendly_names n" to create a multipath.conf with user_friendly_names disabled. If all devices use WWID names, it is always possible for multipath to rename them later.
Fixes b8a92b7 ("multipath: add automatic configuration for multipath")
This pull request changes...
Changes
Checklist
Fixes #
CC: @pvalena @jlebon