8000 Force requirements versioning by TSC21 · Pull Request #34 · dronecrew/px4tools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Force requirements versioning #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 17, 2018
Merged

Force requirements versioning #34

merged 2 commits into from
Jun 17, 2018

Conversation

TSC21
Copy link
Member
@TSC21 TSC21 commented Jun 17, 2018 •
edited
Loading

This PR adds the minimum version for each of the requirements. It's not exactly the minimum for px4tools, as I can't currently tell which is the minimum, but I got as base start the current latest version of the current requirements, except numpy and python-dateutil.
This is to avoid something as http://ci.px4.io:8080/blue/organizations/jenkins/Firmware/detail/PR-9301/16/pipeline/791#step-1104-log-134 to happen.
@lamping7 @dagar FYI.
@jgoppert can you take a look and if it looks good, merge and make a 0.9.5 release to PyPi? Thanks!

@coveralls
Copy link
coveralls commented Jun 17, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 28.631% when pulling 95f0928 on TSC21:pr-update_requirements into 37f4d1f on dronecrew:master.

@TSC21 TSC21 force-pushed the pr-update_requirements branch 5 times, most recently from 55e49df to f470ee7 Compare June 17, 2018 17:13
@TSC21 TSC21 force-pushed the pr-update_requirements branch from f470ee7 to 95f0928 Compare June 17, 2018 17:16
jgoppert
jgoppert approved these changes Jun 17, 2018
View reviewed changes
Copy link
Member
@jgoppert jgoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jgoppert jgoppert merged commit d44c768 into dronecrew:master Jun 17, 2018
@TSC21 TSC21 deleted the pr-update_requirements branch June 17, 2018 17:50
@TSC21 TSC21 mentioned this pull request Jun 17, 2018
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgoppert jgoppert jgoppert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TSC21 @coveralls @jgoppert
0