8000 [release-3.6] pkg/featuregate: Return MutableFeatureGate interface in New function by k8s-infra-cherrypick-robot · Pull Request #19816 · etcd-io/etcd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[release-3.6] pkg/featuregate: Return MutableFeatureGate interface in New function #19816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

[release-3.6] pkg/featuregate: Return MutableFeatureGate interface in New function #19816

merged 1 commit into from
Apr 28, 2025

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #19803

/assign ahrtr

@ivanvc
pkg/featuregate: Return MutableFeatureGate interface in New function
2d8e725 
Avoid returning an unexported struct in the exported New function,
instead return the MutableFeatureGate interface.

Signed-off-by: Ivan Valdes <ivan@vald.es>
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Apr 28, 2025
Merged
@k8s-ci-robot
Copy link

Hi @k8s-infra-cherrypick-robot. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ahrtr
Copy link
Member
ahrtr commented Apr 28, 2025

/ok-to-test

@ahrtr
Copy link
Member
ahrtr commented Apr 28, 2025

/retest

@codecov Codecov
Copy link
codecov bot commented Apr 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.10%. Comparing base (9e6394e) to head (2d8e725).
Report is 2 commits behind head on release-3.6.

Additional details and impacted files
Files with missing lines Coverage Δ
pkg/featuregate/feature_gate.go 88.96% <100.00%> (ø)

... and 59 files with indirect coverage changes

@@               Coverage Diff               @@
##           release-3.6   #19816      +/-   ##
===============================================
- Coverage        68.95%   66.10%   -2.85%     
===============================================
  Files              420      420              
  Lines            35613    35613              
===============================================
- Hits             24557    23543    -1014     
- Misses            9630    10632    +1002     
- Partials          1426     1438      +12

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e6394e...2d8e725. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, k8s-infra-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 5a9094c into etcd-io:release-3.6 Apr 28, 2025
27 of 28 checks passed
@ivanvc ivanvc mentioned this pull request Apr 28, 2025
Closed
4 tasks
@ivanvc ivanvc mentioned this pull request May 28, 2025
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanvc ivanvc ivanvc approved these changes

@ahrtr ahrtr ahrtr approved these changes

Assignees

@ahrtr ahrtr

Labels
approved ok-to-test size/XS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@k8s-infra-cherrypick-robot @k8s-ci-robot @ahrtr @ivanvc
0