8000 decouple raftLog - phase 1: introduce the new type controlflowLog. by IAMRogerXi · Pull Request #292 · etcd-io/raft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

decouple raftLog - phase 1: introduce the new type controlflowLog. #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

decouple raftLog - phase 1: introduce the new type controlflowLog. #292

wants to merge 1 commit into from
+13 −6

Conversation

IAMRogerXi
Copy link
@IAMRogerXi IAMRogerXi commented Apr 29, 2025 •
edited
Loading

#142 - this is about to decouple the type raftLog.

since this change may include a lot of cascaded code changes on several types, i'd like to split this refactor into two phase.

phase 1: introduce the type controlflowLog. add it back into raftLog as embedding type.
i move all control flow related fields into type controlflowLog.

phase 2: remove the embedding type. modify type reference in all other files.

in this PR, i implemented phase 1. please review it.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: IAMRogerXi
Once this PR has been reviewed and has the lgtm label, please assign ptabor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @IAMRogerXi. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@IAMRogerXi IAMRogerXi mentioned this pull request Apr 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-ok-to-test size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IAMRogerXi @k8s-ci-robot @ROXI-MSFT
0