Fix unsat cache in equivalence checking #747
Merged
+16
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently, in a refactoring, the write to the cache disappeared, so the cache was actually always empty. Here we bring back writing to the cache after unsat result. Moreover, we make additional changes related to the cache: Given a set of proposition, we check if it is a *superset* of any known unsatisfiable set of propositions. The previous check for subset relation was not correct: a subset of an unsatiafiable set can be satisfiable. Related to that, we order the queries from the smallest to largest, so that we increase the likelyhood of cache hits.
|
Oh wow, yes. Definitely. It's a superset. And the ordering via I double-checked the superset and indeed it's what we want: ghci> supersetAny a bs = any (`isSubsetOf` a) bs
ghci> supersetAny (fromList [5]) [fromList [5,6]]
Trueand the new compare is also correct: ghci> sortBySize = sortBy (\(a, _) (b, _) -> compare (Set.size a) (Set.size b))
ghci> sortBySize [(fromList [5,6],"a"), (fromList [4], "a")]
[(fromList [4],"a"),(fromList [5,6],"a")]We should do the small ones first, then the supersets will hit more often. I am thinking about merging and rebasing my PR on top of this. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, in a refactoring, the write to the cache disappeared, so the cache was actually always empty.
Here we bring back writing to the cache after unsat result.
Moreover, we make additional changes related to the cache: Given a set of proposition, we check if it is a superset of any known unsatisfiable set of propositions. The previous check for subset relation was not correct: a subset of an unsatiafiable set can be satisfiable.
Related to that, we order the queries from the smallest to largest, so that we increase the likelyhood of cache hits.
Description
Checklist