This repository was archived by the owner on Dec 18, 2019. It is now read-only.
Fix analyzer worker metric assignment #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing formula for computing the fraction of the metrics to process for each worker subprocess could result in situations where the jobs of the last worker overlapped with the ones of the previous worker or even worse, resulted in an index exception. This commit corrects this issue. To visualize the existing issue: With the existing calculations, having 11 metrics and 5 workers resulted in the following provisioning scheme: ``` 1: [0, 1, 2] 2: [3, 4, 5] 3: [6, 7, 8] 4: [9, 10, 11] 5: [8, 9, 10] ``` Worker 4 creates an index error and worker 5 overlaps.
earthgecko
added a commit
to earthgecko/skyline
that referenced
this pull request
Nov 25, 2015
Allow for unique metric tuples to override any metric tuples that are the result of a parent and wildcard namespaces to allow for accurate ttimes_seen conuts for metrics in the alert_threshold context. This allows for 2 levels of declaring a metric namespace, a parent namespace and and this can be overridden by an declaring an absolute metric namespace, only the 2 namespacing types are known to curently work. Started normalising strings in single quotes and added some informational comments. This also sees to etsy/skyline pull request #94 opened by @languitar on 17 Jun 2014 etsy/skyline#94 Fix analyzer worker metric assignment Modified: readme.md src/boundary/alerters.py src/boundary/algorithms.py src/boundary/boundary-agent.py src/boundary/boundary.py src/settings.py.example
earthgecko
added a commit
to earthgecko/skyline
that referenced
this pull request
Nov 25, 2015
…rides Allow for unique metric tuples to override any metric tuples that are the result of a parent and wildcard namespaces to allow for accurate ttimes_seen conuts for metrics in the alert_threshold context. This allows for 2 levels of declaring a metric namespace, a parent namespace and and this can be overridden by an declaring an absolute metric namespace, only the 2 namespacing types are known to curently work. Started normalising strings in single quotes and added some informational comments. This also sees to etsy/skyline pull request #94 opened by @languitar on 17 Jun 2014 etsy/skyline#94 Fix analyzer worker metric assignment Modified: readme.md src/boundary/alerters.py src/boundary/algorithms.py src/boundary/boundary-agent.py src/boundary/boundary.py src/settings.py.example
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion i
30AD
s invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing formula for computing the fraction of the metrics to
process for each worker subprocess could result in situations where the
jobs of the last worker overlapped with the ones of the previous worker
or even worse, resulted in an index exception. This commit corrects this
issue.
To visualize the existing issue: With the existing calculations, having
11 metrics and 5 workers resulted in the following provisioning
scheme:
Worker 4 creates an index error and worker 5 overlaps.