8000 User-defined types and recursive types by albsch · Pull Request #116 · etylizer/etylizer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

User-defined types and recursive types #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 11, 2024
Merged

User-defined types and recursive types #116

merged 10 commits into from
Oct 11, 2024

Conversation

albsch
Copy link
Member
@albsch albsch commented Sep 26, 2024 •
edited
Loading

-type annotation support and recursive types.

  • Modified every method accessing the coinductively-defined ty_rec such that corecursion works properly
  • Moved ast:ty() <-> ty_rec sanity check to the appropriate place
  • Added recursive ast node ty_mu() to ast.erl
  • Hacky way of ensuring uniqueness for recursive variables with erlang:unique_integer()
  • Blocked by Test poly fails with {todo,extract_test_case,memoize_function} #101

@albsch albsch added enhancement New feature or request AST Extension/modification of internal AST structure labels Sep 26, 2024
@albsch albsch added this to the Full Erlang Support milestone Sep 26, 2024
@albsch albsch linked an issue Oct 2, 2024 that may be closed by this pull request
AST: mu nodes #10
Closed
@albsch albsch mentioned this pull request Oct 2, 2024
Closed
@skogsbaer
Copy link
Collaborator

@albsch What's the status here? If we want to do a case study with real world code, we need to support user-defined types.

@albsch albsch force-pushed the as/recursive branch 3 times, most recently from 39df1d8 to d104030 Compare October 10, 2024 08:07
@albsch albsch marked this pull request as ready for review October 10, 2024 08:58
@albsch albsch requested a review from skogsbaer October 10, 2024 09:03
@albsch
Copy link
Member Author
albsch commented Oct 10, 2024

Ready for merge @skogsbaer

@skogsbaer
Copy link
Collaborator

@albsch Passt, jetzt sind aber dummerweise Konflikte da. Sind aber nicht schwer zu fixen.

@albsch albsch merged commit 8bec244 into main Oct 11, 2024
24 checks passed
@albsch albsch mentioned this pull request Oct 14, 2024
Merged
@albsch albsch deleted the as/recursive branch October 29, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skogsbaer skogsbaer skogsbaer approved these changes

Assignees
No one assigned 5444
Labels
AST Extension/modification of internal AST structure enhancement New feature or request
Projects
None yet
Milestone
Full Erlang Support
Development

Successfully merging this pull request may close these issues.

AST: mu nodes
2 participants
@albsch @skogsbaer
0