Support array remove with negative index #60
Conversation
| } | ||
| idx = len(ary) - idx | ||
| } | ||
| if idx < 0 || idx >= len(ary) || idx > len(cur) { |
There was a problem hiding this comment.
I believe the > and >= checks here are redundant so I removed one of them.
There was a problem hiding this comment.
Also, multiplying the index by -1 before reporting an error made the error message a bit misleading, so I check the index before altering it.
|
Sorry about that last comment. Put it on the wrong PR. ;) . I think this PR should work fine. I'm resolving the changes after you merged my other PR (thanks for that!). |
|
I don’t believe negative indexes are in the RFC... |
|
I did a quick check @evanphx JSON Patch RFC 6902 section 4.1:
JSON Pointer RFC 6901 Section 4
So it seems like only The repo currently supports the use of negative indexes, as indicated in this test. So I'd think this PR would be a good addition for now, and if you wanted to remove the ability to specify negative indices that might be best tackled in a separate pr? |
|
FWIW, I created this PR just because I wanted the error handling. But when I saw that “add” handled negative indices, I figured we needed to support that as well. We personally don’t use or expect them. |
Also return an error when when a negative index is out of range