8000 add base code for testnet by nghuyenthevinh2000 · Pull Request #34 · eve-network/eve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add base code for testnet #34

New issue
8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 15, 2022
Merged

add base code for testnet #34

merged 7 commits into from
Sep 15, 2022

Conversation

nghuyenthevinh2000
Copy link
Collaborator
@nghuyenthevinh2000 nghuyenthevinh2000 commented Sep 13, 2022

add cmd, script for testnet

@faddat
Copy link
Contributor
faddat commented Sep 14, 2022

very hot.

@nghuyenthevinh2000 nghuyenthevinh2000 marked this pull request as ready for review September 15, 2022 03:21
@@ -200,7 +200,7 @@ func initRootCmd(rootCmd *cobra.Command, encodingConfig params.EncodingConfig) {
genutilcli.ValidateGenesisCmd(app.ModuleBasics),
AddGenesisAccountCmd(app.DefaultNodeHome),
tmcli.NewCompletionCmd(rootCmd, true),
// NewTestnetCmd(app.ModuleBasics, banktypes.GenesisBalancesIterator{}),
testnetCmd(app.ModuleBasics, banktypes.GenesisBalancesIterator{}),
Copy link
Contributor
@Reecepbcups Reecepbcups Sep 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We removed this since we are going to have to test with docker / compose

also if we did use it,
eved testnet init
Error: unable to resolve type URL /cosmos.staking.v1beta1.MsgCreateValidator

built in testnet is too hard to add custom logic for, might as well just run natively & not use the SDK testnet at all

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like it in


# Start a 4-node testnet locally
localnet-start: localnet-clean
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker-compose down
sudo rm -rf build
rm mnemonics.txt
rm: cannot remove 'mnemonics.txt': No such file or directory
make: *** [Makefile:160: localnet-clean] Error 1

Should run the add-keys.sh script here automatically?
when I run manually

Could not open file build/node3/eved/key_seed.json: No such file or directory

also mainnet = eve-1, so should do eve-t1 or l1 for test/local version

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not have sudo in a makefile

Comment on lines +95 to +100
## Starting localnet

```
make install
make localnet-build
make localnet-start
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(vinh/testnet-cmd) -> $ make localnet-start
docker-compose down
sudo rm -rf build
rm mnemonics.txt
rm: cannot remove 'mnemonics.txt': No such file or directory
make: *** [Makefile:160: localnet-clean] Error 1

@faddat
Copy link
Contributor
faddat commented Sep 15, 2022

@Reecepbcups if we can use the sdk's native testnet, I'd like to.

can we keep makefile changes for the docker based testnetting to another pr?

Also, I think that we should keep the docker based testnet.

@faddat faddat merged commit b988f6f into main Sep 15, 2022
@hoank101 hoank101 deleted the vinh/testnet-cmd branch March 19, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0