8000 Add sentry by gBillal · Pull Request #653 · evercam/ex_nvr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add sentry #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 25, 2025
Merged

Add sentry #653

merged 3 commits into from
Apr 25, 2025

Conversation

gBillal
Copy link
Member
@gBillal gBillal commented Apr 25, 2025

No description provided.

@gBillal gBillal requested a review from Copilot April 25, 2025 16:21
Copy link

📦 To trigger a firmware build, comment /build below.
To build a specific target, comment /build <target> with on of the following targets
Valid target names:

  • ex_nvr_rpi4
  • ex_nvr_rpi5
  • giraffe

You can also specify a custom version: /build <target> version=<version>
Examples:
/build version=1.0.0-test
/build ex_nvr_rpi5 version=1.0.0-test.123

If no version is specified, one will be generated automatically.

Copy link
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces Sentry integration by packaging source code for Sentry in two GitHub Actions workflows. The changes include updating the release workflow to run Sentry packaging alongside building the release and adding a dedicated Sentry packaging step and environment variable (SENTRY_DSN) in the nerves workflow.

Reviewed Changes

Copilot reviewed 5 out of 18 changed files in this pull request and generated no comments.

File Description
.github/workflows/release.yml Updated release command to include Sentry packaging
.github/workflows/nerves.yml Added SENTRY_DSN environment variable and a new step for packaging source code for Sentry
Files not reviewed (13)
  • .github/workflows/Dockerfile: Language not supported
  • .github/workflows/Dockerfile-arm: Language not supported
  • Dockerfile: Language not supported
  • nerves_fw/config/target.exs: Language not supported
  • nerves_fw/lib/nerves_fw/hardware/rut.ex: Language not supported
  • ui/config/dev.exs: Language not supported
  • ui/config/prod.exs: Language not supported
  • ui/lib/ex_nvr/sentry.ex: Language not supported
  • ui/lib/ex_nvr_web.ex: Language not supported
  • ui/lib/ex_nvr_web/application.ex: Language not supported
  • ui/lib/ex_nvr_web/endpoint.ex: Language not supported
  • ui/lib/ex_nvr_web/live/user_list_live.ex: Language not supported
  • ui/mix.exs: Language not supported
Comments suppressed due to low confidence (2)

.github/workflows/release.yml:34

  • Ensure that combining 'sentry.package_source_code' with 'release' in a single mix command does not cause unintended side effects in the release process. Consider testing that both operations execute in the correct order, or separate them if any issues arise.
run: mix do sentry.package_source_code, release

.github/workflows/nerves.yml:111

  • Confirm that running 'mix sentry.package_source_code' as a standalone step after dependency installation correctly integrates with the firmware build process. Consistency in the Sentry integration approach across workflows should be verified.
- name: Package source code for sentry

@gBillal gBillal merged commit 0b1200f into master Apr 25, 2025
1 check passed
@gBillal gBillal deleted the add-sentry branch April 25, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0