Add custom live pages/controllers/rest api for nerves only #686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 To trigger a firmware build, comment
You can also specify a custom version: If no version is specified, one will be generated automatically. |
|
Good, this achieves the desired outcome, with minimal / straightforward changes. |
This was referenced May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an ugly solution for extending the ExNVR UI with live pages/controllers/rest API for nerves. The idea is to not make ExNVR UI extendable or introduce any fancy plugin systems for now. Since the nerves image is tailored for Evercam use cases, we want to hide those from the open source/generic NVR.
For this, we'll only add a compile environment variable
nerves_routes, if set all the additional pages/controllers/rest APIs will be included. The side bar menus will also be controlled by a simple:Application.get_env(:ex_nvr, :nerves_routes). And I suspect we can do the same thing with other assets (javascript, css, ...etc).If the need rise, we may create a proper plugin system.
@halimb can you give it a try !!