Add __hash__ on data types #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@m-burst This looks great; thanks a lot! Can you also add a test to make sure that the hash is in fact the same for identical data types? It's just nice to have a test both for the positive case and for the negative case. |
The added implementation XORs the `tuple.__hash__` of the data object with the hash of the class. This should help to avoid collisions between instances of different data types with identical members. Also added a test which ensures that: * hash of a data type instance can be computed; * hashes of instances of different data types with same data differ; * hash of a data type instance differs from hash of a plain tuple. Fixes #446.
|
@evhub Added a simple positive test case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The added implementation XORs the
tuple.__hash__of the data object with the hash of the class. This should help to avoid collisions between instances of different data types with identical members.Also added a test which ensures that:
Fixes #446.