Issue #587 Add --and for doing extra compilation with the same arguments #595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `--and` kwarg to CLI - Factor out _process_source_dest_pairs for cleaner itteration TODO: Tests
|
@nlipsyc This looks great—thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add the option to include
--and additional/src additional/destto the CLI arguments. It works under the assumption that other flags that are passed should apply to all source/dest pairs.In addition to the automated test, I did some manual testing. It confirmed that compiling multiples of the same file to different destinations, and multiples of different files to the same destination worked as expected. This was both with overlapping and non-overlapping names. This was tested with up to 2
--andpairs.