8000 Adds groupsof built-in by kbaskett248 · Pull Request #309 · evhub/coconut · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Adds groupsof built-in #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 29, 2017
Merged

Adds groupsof built-in #309

merged 10 commits into from
Aug 29, 2017

Conversation

kbaskett248
Copy link
Contributor

This resolves #297.

@kbaskett248
Adds basic groupsof implementation
6d8dca4 
No tests have been added, but existing tests run.
@kbaskett248
Adds tests for groupsof command
1efbd5e
@kbaskett248
Fixes some bugs with the groupsof implementation
69a0ad6
@kbaskett248
Adds argument validation for group size argument
74ceeef 
Also renames the class variable for the iterable to match other built-ins.
@kbaskett248
groupsof no longer crashes on the repl
152e62a 
groupsof was crashing on the repl when the group size evenly divided
the iterable size with a StopIteration exception. I'm not sure why
this wasn't happening in the tests.
@kbaskett248
Adds tests for groupsof argument validation
a69f73e
@kbaskett248
Documents the groupsof built-in
85a8a5d
@kbaskett248
Merge pull request #1 from kbaskett248/groupsof
154d6ac 
Adds groupsof built-in
@kbaskett248
Documentation fix for groupsof python example
9257915
@kbaskett248
Additional documentation to clarify groupsof
2e7cfde
@kbaskett248
Copy link
Contributor Author

@evhub I'm not totally sure, but these failures seem unrelated to my changes. The AppVeyor failures look like they result from Jupyter not installing.

@evhub evhub self-requested a review August 29, 2017 20:16
@evhub evhub added the feature label Aug 29, 2017
@evhub evhub added this to the v1.3.0 milestone Aug 29, 2017
@evhub
Copy link
Owner
evhub commented Aug 29, 2017

@kbaskett248 You can ignore AppVeyor; Travis is what matters. AppVeyor is currently breaking on develop, that's a known issue I haven't gotten around to fixing yet.

I haven't had a chance to look at your code yet, but I should be able to later today!

@evhub
Copy link
Owner
evhub commented Aug 29, 2017

@kbaskett248 This looks great (seriously, I mean it, this looks really nice)! I'll go ahead and merge this into develop now, and I'll also go ahead and bump the coconut-develop version so it'll be accessible with pip install coconut-develop. I'm planning on releasing v1.3.0 pretty soon, and I will definitely be including this in that release, so it should soon be available in production! Looking forward to more great contributions from you in the future!

@evhub evhub merged commit 02bd281 into evhub:develop Aug 29, 2017
@evhub evhub mentioned this pull request Sep 2, 2017
Merged
@evhub evhub added the resolved label Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evhub evhub Awaiting requested review from evhub

Assignees
No one assigned
Labels
feature resolved
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kbaskett248 @evhub
0