Support input types #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR adds support for input types—including string, number, and boolean—by updating input parsing, validation, and default handling. Key changes include:
- Changing the type of input default and option values to be type-agnostic and adding min/max validation for number types.
- Updating YAML unmarshalling to support both sequence and mapping representations of options while validating type consistency.
- Extending tests and documentation to cover the new input types and their behavior.
Reviewed Changes
| File | Description |
|---|---|
| config.go | Updated input option structure, YAML unmarshalling, parsing, and validation to support number and boolean types. |
| utils_test.go | Added tests to verify type conversion in ToFloat64. |
| config_test.go | Extended tests for input parsing, default values, and error handling for new types. |
| utils.go | Added a new implementation of ToFloat64 (potential duplicate). |
| command_set_test.go | Added tests for argument parsing with number and boolean types. |
| command_set.go | Updated default value handling and environment variable parsing for typed inputs. |
| README.md | Updated documentation to describe the new input type support and configuration options. |
| prompt.go | Modified prompt functions to return non-string types where applicable. |
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
utils.go:123
- The function ToFloat64 appears to be defined twice in utils.go, which may lead to duplicate symbol errors. Consider removing the redundant implementation.
func ToFloat64(value any) float64 {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for specifying input types, such as
string,number, andboolean. Also added additional configuration to validate numbers withminandmax.Checklist
Thanks for contributing!