8000 fix(rpc): fix panic on breaking EVM and feemarket params by fedekunze · Pull Request #1188 · evmos/ethermint · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Apr 4, 2024. It is now read-only.

fix(rpc): fix panic on breaking EVM and feemarket params #1188

Merged
merged 8 commits into from
Jul 19, 2022
Merged

fix(rpc): fix panic on breaking EVM and feemarket params #1188

merged 8 commits into from
Jul 19, 2022

Conversation

fedekunze
Copy link
Collaborator
@fedekunze fedekunze commented Jul 18, 2022 •
edited
Loading

Closes: #1190

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze changed the title fedekunze/fix params fix(rpc): fix panic on breaking EVM and feemarket params Jul 18, 2022
@codecov
Copy link
codecov bot commented Jul 18, 2022 •
edited
Loading

Codecov Report

Merging #1188 (b37de8f) into main (ea81e15) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

❗ Current head b37de8f differs from pull request most recent head 2773d68. Consider uploading reports for the commit 2773d68 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1188      +/-   ##
==========================================
- Coverage   62.27%   62.10%   -0.17%     
==========================================
  Files          91       91              
  Lines        7369     7363       -6     
==========================================
- Hits         4589     4573      -16     
- Misses       2553     2562       +9     
- Partials      227      228       +1
Impacted Files Coverage Δ
x/evm/keeper/params.go 100.00% <100.00%> (ø)
x/feemarket/keeper/params.go 82.35% <100.00%> (+5.42%) ⬆️
x/evm/keeper/msg_server.go 85.10% <0.00%> (-5.32%) ⬇️
x/evm/keeper/state_transition.go 74.77% <0.00%> (-2.13%) ⬇️
x/evm/keeper/keeper.go 79.11% <0.00%> (-1.90%) ⬇️
x/evm/types/msg.go 83.67% <0.00%> (-0.25%) ⬇️
x/evm/types/errors.go 100.00% <0.00%> (ø)
app/app.go 86.00% <0.00%> (+0.03%) ⬆️
app/ante/ante.go 58.18% <0.00%> (+3.00%) ⬆️

@github-actions github-actions bot added the Type: CI continuous integration label Jul 18, 2022
@fedekunze fedekunze marked this pull request as ready for review July 18, 2022 20:11
@fedekunze fedekunze added the backport/0.17.x PR scheduled for inclusion in the v0.17's next stable release label Jul 18, 2022
@fedekunze fedekunze merged commit 73c9ea2 into main Jul 19, 2022
@fedekunze fedekunze deleted the fedekunze/fix-params branch July 19, 2022 15:00
mergify bot pushed a commit that referenced this pull request Jul 19, 2022
@fedekunze @mergify
fix(rpc): fix panic on breaking EVM and feemarket params (#1188)
cedb6d0 
* release: v0.17.0 changelog (#1153)

* release: v0.17.0 changelog

* rm newline

* update link

* fix(rpc): fix panic on breaking EVM and feemarket params

* changelog

* fix gosec

(cherry picked from commit 73c9ea2)

# Conflicts:
#	.mergify.yml
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request Jul 19, 2022
Merged
fedekunze added a commit that referenced this pull request Jul 19, 2022
@mergify @fedekunze
fix(rpc): fix panic on breaking EVM and feemarket params (backport #1188
f740e13 
) (#1193)

* fix(rpc): fix panic on breaking EVM and feemarket params (#1188)

* release: v0.17.0 changelog (#1153)

* release: v0.17.0 changelog

* rm newline

* update link

* fix(rpc): fix panic on breaking EVM and feemarket params

* changelog

* fix gosec

(cherry picked from commit 73c9ea2)

# Conflicts:
#	.mergify.yml
#	CHANGELOG.md

* Update .mergify.yml

* fix

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
hoanguyenkh pushed a commit to AstraProtocol/ethermint that referenced this pull request Jul 27, 2022
@fedekunze
fix(rpc): fix panic on breaking EVM and feemarket params (evmos#1188)
45d4591 
* release: v0.17.0 changelog (evmos#1153)

* release: v0.17.0 changelog

* rm newline

* update link

* fix(rpc): fix panic on breaking EVM and feemarket params

* changelog

* fix gosec
hoanguyenkh pushed a commit to AstraProtocol/ethermint that referenced this pull request Jul 27, 2022
@mergify @fedekunze
fix(rpc): fix panic on breaking EVM and feemarket params (backport ev…
64cd1b7 
…mos#1188) (evmos#1193)

* fix(rpc): fix panic on breaking EVM and feemarket params (evmos#1188)

* release: v0.17.0 changelog (evmos#1153)

* release: v0.17.0 changelog

* rm newline

* update link

* fix(rpc): fix panic on breaking EVM and feemarket params

* changelog

* fix gosec

(cherry picked from commit 73c9ea2)

# Conflicts:
#	.mergify.yml
#	CHANGELOG.md

* Update .mergify.yml

* fix

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
devon-chain pushed a commit to devon-chain/ethermint that referenced this pull request Aug 2, 2022
@fedekunze @devon-chain
fix(rpc): fix panic on breaking EVM and feemarket params (evmos#1188)
788818b 
* release: v0.17.0 changelog (evmos#1153)

* release: v0.17.0 changelog

* rm newline

* update link

* fix(rpc): fix panic on breaking EVM and feemarket params

* changelog

* fix gosec
devon-chain pushed a commit to PundiAI/ethermint-old that referenced this pull request Nov 17, 2022
@fedekunze @devon-chain
fix(rpc): fix panic on breaking EVM and feemarket params (evmos#1188)
99c557f 
* release: v0.17.0 changelog (evmos#1153)

* release: v0.17.0 changelog

* rm newline

* update link

* fix(rpc): fix panic on breaking EVM and feemarket params

* changelog

* fix gosec
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crypto-facs crypto-facs crypto-facs approved these changes

@khoslaventures khoslaventures Awaiting requested review from khoslaventures

@jolube jolube Awaiting requested review from jolube

Assignees
No one assigned
Labels
backport/0.17.x PR scheduled for inclusion in the v0.17's next stable release Type: CI continuous integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UnmarshalJSON error on JSON-RPC
2 participants
@fedekunze @crypto-facs
0