8000
app: fix typo in calculation of failed transactions in TPS value #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed while I was auditing through evmosd code that inside the code that records TPS, that we have a typo in the calculation of nFailed, that instead used latestNSuccessful, of which if enough time is spent and the successful transactions have grown, while the number of failed transactions stays still, this can cause wrong TPS values to be reported.
Codecov Report
@@ Coverage Diff @@
## main #149 +/- ##
=======================================
Coverage 72.43% 72.43%
=======================================
Files 24 24
Lines 1698 1698
=======================================
Hits 1230 1230
Misses 416 416
Partials 52 52
|
fedekunze
approved these changes
Dec 6, 2021
mergify bot
pushed a commit
that referenced
this pull request
Dec 7, 2021
Noticed while I was auditing through evmosd code that inside the code that records TPS, that we have a typo in the calculation of nFailed, that instead used latestNSuccessful, of which if enough time is spent and the successful transactions have grown, while the number of failed transactions stays still, this can cause wrong TPS values to be reported. Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> (cherry picked from commit 7603acd)
faddat
referenced
this pull request
in notional-labs/evmos
Dec 9, 2021
fedekunze
added a commit
that referenced
this pull request
Dec 12, 2021
* release: v0.4.0 changelog (#138) * release(evmos): Update CHANGELOG * Update CHANGELOG.md Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * Fix `evmosd version` (backport #151) (#154) * Fix `evmosd version` (#151) * build(deps): bump github.com/cosmos/ibc-go/v2 from 2.0.0 to 2.0.1 (#150) Bumps [github.com/cosmos/ibc-go/v2](https://github.com/cosmos/ibc-go) from 2.0.0 to 2.0.1. - [Release notes](https://github.com/cosmos/ibc-go/releases) - [Changelog](https://github.com/cosmos/ibc-go/blob/v2.0.1/CHANGELOG.md) - [Commits](cosmos/ibc-go@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: github.com/cosmos/ibc-go/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build fix evmosd command * Update CHANGELOG.md Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> (cherry picked from commit 5061449) # Conflicts: # CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Prajjwol Gautam <prajjwol@gmail.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * app: fix typo in calculation of failed transactions in TPS value (#149) (#155) Noticed while I was auditing through evmosd code that inside the code that records TPS, that we have a typo in the calculation of nFailed, that instead used latestNSuccessful, of which if enough time is spent and the successful transactions have grown, while the number of failed transactions stays still, this can cause wrong TPS values to be reported. Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> (cherry picked from commit 7603acd) Co-authored-by: Emmanuel T Odeke <emmanuel@orijtech.com> * Release CHANGELOG v0.4.1 (#157) * docs(evmos): update latest version to v0.4.0 (#139) 8000 * docs: change `ethermintd` -> `evmosd` (#142) * docs: migrate cosmovisor and genesis validator instructions (#141) * docs(evmos): Add upgrade node with cosmovisor instructions * docs(evmos): Add Incorporate changes from Cosmos Hub Vega Upgrade * Apply suggestions from code review * go mod tidy Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com> * build: added build-reproducible to Makefile (#143) * release: v0.4.0 changelog (#138) * release(evmos): Update CHANGELOG * Update CHANGELOG.md Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * (build): added build-reproducible to makefile Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com> * docs: Add link to consensus problems if you don't upgrade your node (#146) Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * deps: bump SDK version (#147) * deps: bump SDK version * norace * build(deps): bump github.com/cosmos/ibc-go/v2 from 2.0.0 to 2.0.1 (#150) Bumps [github.com/cosmos/ibc-go/v2](https://github.com/cosmos/ibc-go) from 2.0.0 to 2.0.1. - [Release notes](https://github.com/cosmos/ibc-go/releases) - [Changelog](https://github.com/cosmos/ibc-go/blob/v2.0.1/CHANGELOG.md) - [Commits](cosmos/ibc-go@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: github.com/cosmos/ibc-go/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ci: mergify changes (#152) * Fix `evmosd version` (#151) * build(deps): bump github.com/cosmos/ibc-go/v2 from 2.0.0 to 2.0.1 (#150) Bumps [github.com/cosmos/ibc-go/v2](https://github.com/cosmos/ibc-go) from 2.0.0 to 2.0.1. - [Release notes](https://github.com/cosmos/ibc-go/releases) - [Changelog](https://github.com/cosmos/ibc-go/blob/v2.0.1/CHANGELOG.md) - [Commits](cosmos/ibc-go@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: github.com/cosmos/ibc-go/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build fix evmosd command * Update CHANGELOG.md Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * app: fix typo in calculation of failed transactions in TPS value (#149) Noticed while I was auditing through evmosd code that inside the code that records TPS, that we have a typo in the calculation of nFailed, that instead used latestNSuccessful, of which if enough time is spent and the successful transactions have grown, while the number of failed transactions stays still, this can cause wrong TPS values to be reported. Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * Update .goreleaser.yml (#156) Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com> Co-authored-by: Rohit Durvasula <88731568+rohitbison@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com> Co-authored-by: Prajjwol Gautam <prajjwol@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Emmanuel T Odeke <emmanuel@orijtech.com> * fix: upgrade handler for v0.4.1 (#166) * release: handler fix changelog (#167) * docs(evmos): update latest version to v0.4.0 (#139) * docs: change `ethermintd` -> `evmosd` (#142) * docs: migrate cosmovisor and genesis validator instructions (#141) * docs(evmos): Add upgrade node with cosmovisor instructions * docs(evmos): Add Incorporate changes from Cosmos Hub Vega Upgrade * Apply suggestions from code review * go mod tidy Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com> * build: added build-reproducible to Makefile (#143) * release: v0.4.0 changelog (#138) * release(evmos): Update CHANGELOG * Update CHANGELOG.md Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * (build): added build-reproducible to makefile Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com> * docs: Add link to consensus problems if you don't upgrade your node (#146) Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * deps: bump SDK version (#147) * deps: bump SDK version * norace * build(deps): bump github.com/cosmos/ibc-go/v2 from 2.0.0 to 2.0.1 (#150) Bumps [github.com/cosmos/ibc-go/v2](https://github.com/cosmos/ibc-go) from 2.0.0 to 2.0.1. - [Release notes](https://github.com/cosmos/ibc-go/releases) - [Changelog](https://github.com/cosmos/ibc-go/blob/v2.0.1/CHANGELOG.md) - [Commits](cosmos/ibc-go@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: github.com/cosmos/ibc-go/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ci: mergify changes (#152) * Fix `evmosd version` (#151) * build(deps): bump github.com/cosmos/ibc-go/v2 from 2.0.0 to 2.0.1 (#150) Bumps [github.com/cosmos/ibc-go/v2](https://github.com/cosmos/ibc-go) from 2.0.0 to 2.0.1. - [Release notes](https://github.com/cosmos/ibc-go/releases) - [Changelog](https://github.com/cosmos/ibc-go/blob/v2.0.1/CHANGELOG.md) - [Commits](cosmos/ibc-go@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: github.com/cosmos/ibc-go/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build fix evmosd command * Update CHANGELOG.md Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * app: fix typo in calculation of failed transactions in TPS value (#149) Noticed while I was auditing through evmosd code that inside the code that records TPS, that we have a typo in the calculation of nFailed, that instead used latestNSuccessful, of which if enough time is spent and the successful transactions have grown, while the number of failed transactions stays still, this can cause wrong TPS values to be reported. Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * Update .goreleaser.yml (#156) * docs: block explorer (#158) * docs: quick facts table (#159) * docs: quick facts table * Update docs/basics/chain_id.md * changelog Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com> Co-authored-by: Rohit Durvasula <88731568+rohitbison@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com> Co-authored-by: Prajjwol Gautam <prajjwol@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Emmanuel T Odeke <emmanuel@orijtech.com> * fix: intrarelayer testnet fixes * fix tests * lint * comments Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Prajjwol Gautam <prajjwol@gmail.com> Co-authored-by: Emmanuel T Odeke <emmanuel@orijtech.com> Co-authored-by: Joe Schmoe <64335177+jolube@users.noreply.github.com> Co-authored-by: Rohit Durvasula <88731568+rohitbison@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Giancarlos Salas <giansalex@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while I was auditing through evmosd code that inside
the code that records TPS, that we have a typo in the calculation
of nFailed, that instead used latestNSuccessful, of which if enough
time is spent and the successful transactions have grown, while
the number of failed transactions stays still, this can cause
wrong TPS values to be reported.