8000 fix(rpc): concurrent map iteration and write by GAtom22 · Pull Request #1646 · evmos/evmos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(rpc): concurrent map iteration and write #1646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

fix(rpc): concurrent map iteration and write #1646

wants to merge 6 commits into from

Conversation

GAtom22
Copy link
Contributor
@GAtom22 GAtom22 commented Jul 5, 2023 •
edited
Loading

Description

This PR introduces the changes to solve reported racing conditions on the RPC pubSub logic

Reported issue logs:

fatal error: concurrent map iteration and map write

goroutine 12880390 [running]:
github.com/evmos/evmos/v12/rpc/ethereum/pubsub.(*memEventBus).publishAllSubscribers(0xc106c0b500, {0xc000fdab80?, 0xe53d86?}, {{0xc4b4d0baa0, 0x19}, {0x2987720, 0xc2bdef9880}, 0xc4b714af30})
	/go/src/github.com/tharsis/evmos/rpc/ethereum/pubsub/pubsub.go:152 +0x16f
github.com/evmos/evmos/v12/rpc/ethereum/pubsub.(*memEventBus).publishTopic(0xc106c0b500, {0xc000fdab80, 0x19}, 0xc1051f8bd0?)
...

Closes #XXX

@GAtom22 GAtom22 requested a review from facs95 July 5, 2023 18:04
@GAtom22 GAtom22 marked this pull request as ready for review July 5, 2023 18:07
@GAtom22 GAtom22 requested a review from a team as a code owner July 5, 2023 18:07
@GAtom22 GAtom22 requested review from MalteHerrmann and removed request for a team July 5, 2023 18:07
@GAtom22 GAtom22 requested a review from fedekunze July 5, 2023 18:11
@github-actions github-actions bot added the build label Jul 5, 2023
@codecov
Copy link
codecov bot commented Jul 5, 2023

Codecov Report

Merging #1646 (7361a8a) into main (3dc4511) will increase coverage by 0.03%.
The diff coverage is 81.08%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1646      +/-   ##
==========================================
+ Coverage   72.90%   72.94%   +0.03%     
==========================================
  Files         291      291              
  Lines       21226    21225       -1     
==========================================
+ Hits        15475    15482       +7     
+ Misses       5002     4994       -8     
  Partials      749      749
Impacted Files Coverage Δ
tests/e2e/upgrade/node.go 0.00% <0.00%> (ø)
rpc/ethereum/pubsub/pubsub.go 85.39% <83.33%> (+9.56%) ⬆️

@GAtom22
Copy link
Contributor Author
GAtom22 commented Jul 5, 2023

Closed in favor of #1650

@GAtom22 GAtom22 closed this Jul 5, 2023
@0xstepit 0xstepit deleted the GAtom22/racing branch January 26, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facs95 facs95 Awaiting requested review from facs95

@MalteHerrmann MalteHerrmann Awaiting requested review from MalteHerrmann MalteHerrmann is a code owner automatically assigned from evmos/core-engineering

@fedekunze fedekunze Awaiting requested review from fedekunze

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GAtom22
0