8000 fix: avoid channel get changed when concurrent subscribe happens by mmsqe · Pull Request #1655 · evmos/evmos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: avoid channel get 8000 changed when concurrent subscribe happens #1655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 14, 2023
Merged

fix: avoid channel get changed when concurrent subscribe happens #1655

merged 3 commits into from
Jul 14, 2023

Conversation

mmsqe
Copy link
Contributor
@mmsqe mmsqe commented Jul 13, 2023

Description

for more info

@mmsqe mmsqe marked this pull request as ready for review July 13, 2023 01:37
@mmsqe mmsqe requested a review from a team as a code owner July 13, 2023 01:37
@mmsqe mmsqe requested review from facs95 and GAtom22 and removed request for a team July 13, 2023 01:37
@codecov
Copy link
codecov bot commented Jul 13, 2023 •
edited
Loading

Codecov Report

Merging #1655 (eaf083c) into main (b92fe2d) will decrease coverage by 2.69%.
The diff coverage is 100.00%.

❗ Current head eaf083c differs from pull request most recent head 2baa488. Consider uploading reports for the commit 2baa488 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1655      +/-   ##
==========================================
- Coverage   72.94%   70.25%   -2.69%     
==========================================
  Files         291      296       +5     
  Lines       21227    22059     +832     
==========================================
+ Hits        15484    15498      +14     
- Misses       4994     5812     +818     
  Partials      749      749
Impacted Files Coverage Δ
...c/namespaces/ethereum/eth/filters/filter_system.go 7.86% <100.00%> (ø)

... and 4 files with indirect coverage changes

facs95
facs95 approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor
@facs95 facs95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@CLAassistant
Copy link
CLAassistant commented Jul 14, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@facs95 facs95 enabled auto-merge (squash) July 14, 2023 23:40
@facs95 facs95 merged commit 5d08970 into evmos:main Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facs95 facs95 facs95 approved these changes

@GAtom22 GAtom22 Awaiting requested review from GAtom22 GAtom22 is a code owner automatically assigned from evmos/core-engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmsqe @CLAassistant @facs95
0