8000 fix(staking): return single struct responses for queries (backport #1734) by mergify[bot] · Pull Request #1748 · evmos/evmos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(staking): return single struct responses for queries (backport #1734) #1748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(staking): return single struct responses for queries (backport #1734) #1748

wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor
@mergify mergify bot commented Sep 5, 2023

This is an automatic backport of pull request #1734 done by Mergify.
Cherry-pick of e47d230 has failed:

On branch mergify/bp/release/v14.0.x/pr-1734
Your branch is up to date with 'origin/release/v14.0.x'.

You are currently cherry-picking commit e47d2307.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   precompiles/staking/Staking.sol
	modified:   precompiles/staking/abi.json
	modified:   precompiles/staking/integration_test.go
	modified:   precompiles/staking/query.go
	modified:   precompiles/staking/query_test.go
	modified:   precompiles/staking/testdata/StakingCaller.json
	modified:   precompiles/staking/testdata/StakingCaller.sol
	modified:   precompiles/staking/types.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@Vvaradinov @mergify
fix(staking): return single struct responses for queries (#1734)
bc8469c 
* fix: modify Staking interface and regenerate abi.json

* fix: adjust return responses

* fix: convert return types for queries into single structs

* add CHANGELOG

* fix: CHANGELOG

(cherry picked from commit e47d230)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot requested a review from a team as a code owner September 5, 2023 15:05
@mergify mergify bot requested review from MalteHerrmann and 0xstepit September 5, 2023 15:05
@mergify mergify bot added the conflicts label Sep 5, 2023
@mergify mergify bot mentioned this pull request Sep 5, 2023
Merged
@codecov
Copy link
codecov bot commented Sep 5, 2023

Codecov Report

Merging #1748 (bc8469c) into release/v14.0.x (a6cb40a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v14.0.x    #1748      +/-   ##
===================================================
+ Coverage            70.46%   70.47%   +0.01%     
===================================================
  Files                  312      312              
  Lines                23191    23199       +8     
===================================================
+ Hits                 16342    16350       +8     
  Misses                6033     6033              
  Partials               816      816
Files Changed Coverage
precompiles/staking/query.go 100.00%
precompiles/staking/types.go 100.00%

@Vvaradinov Vvaradinov closed this Sep 7, 2023
@mergify mergify bot deleted the mergify/bp/release/v14.0.x/pr-1734 branch September 7, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MalteHerrmann MalteHerrmann Awaiting requested review from MalteHerrmann MalteHerrmann is a code owner automatically assigned from evmos/core-engineering

@0xstepit 0xstepit Awaiting requested review from 0xstepit 0xstepit is a code owner automatically assigned from evmos/core-engineering

Assignees
No one assigned
Labels
conflicts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Vvaradinov
0