8000 fix(authz): remove distribution authorizations from testnet by MalteHerrmann · Pull Request #1957 · evmos/evmos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(authz): remove distribution authorizations from testnet #1957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 27, 2023
Merged

fix(authz): remove distribution authorizations from testnet #1957

merged 13 commits into from
Oct 27, 2023

Conversation

MalteHerrmann
Copy link
Contributor

Description

This PR adds the necessary logic to remove the distribution authorizations from testnet. For context, this authz type was only added for release candidates on testnet and removed thereafter. Since switching to a Cosmos SDK version that didn't contain this data type, e.g. the evmosd q authz grants-by-grantee query is broken. The remnant data on testnet needs to be removed in order for this to be fixed.

Closes ENG-2256

@linear
Copy link
linear bot commented Oct 27, 2023
ENG-2256 Fix grants query because of Distribution authorization

Context

Currently the query for grants by grantee on testnet is broken. This is the case because of the DistributionAuthorization type which was present in v13.0.0-rc2 and was issued to a couple of test addresses. Afterwards this type was removed but the store entries have not been removed at that point. Since upgrading to a version of the Cosmos SDK v0.47.x (happened in v14.0.0-rc2), the following query is broken, because it iterates over all store entries and then finds the now invalid distribution authorizations.

Expected

Fix the query. This will probably include re-adding the deleted type on the Cosmos SDK.

@fedekunze
Copy link
Collaborator

@MalteHerrmann please rebase to main. PRs should always be merged to main and then backported to the release

fedekunze
fedekunze reviewed Oct 27, 2023
View reviewed changes
Base automatically changed from malte/prepare-v15.0.0-rc2 to release/v15.0.x October 27, 2023 10:21
@codecov
Copy link
codecov bot commented Oct 27, 2023 •
edited
Loading

Codecov Report

Merging #1957 (da5cbae) into release/v15.0.x (d8eba37) will increase coverage by 0.01%.
The diff coverage is 42.30%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v15.0.x    #1957      +/-   ##
===================================================
+ Coverage            70.35%   70.37%   +0.01%     
===================================================
  Files                  319      319              
  Lines                23540    23528      -12     
===================================================
- Hits                 16562    16557       -5     
+ Misses                6158     6149       -9     
- Partials               820      822       +2
Files Coverage Δ
app/app.go 81.17% <100.00%> (+0.24%) ⬆️
app/upgrades/v15rc2/upgrades.go 35.48% <40.00%> (ø)

fedekunze
fedekunze reviewed Oct 27, 2023
View reviewed changes
fedekunze
fedekunze reviewed Oct 27, 2023
View reviewed changes
0xstepit
0xstepit approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor
@0xstepit 0xstepit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @MalteHerrmann !

fedekunze and others added 4 commits October 27, 2023 14:48
@fedekunze @0xstepit
Update app/upgrades/v15rc2/upgrades.go
271996e 
Co-authored-by: stepit <48993133+0xstepit@users.noreply.github.com>
remove v15.0.0-rc1 logic
40fd7ee
Merge remote-tracking branch 'origin/release/v15.0.x' into malte/remo…
b1275e5 
…ve-dist-authz-testnet

# Conflicts:
#	app/app.go
#	app/upgrades/v15rc2/upgrades.go
fix dead markdown link
da5cbae
@MalteHerrmann MalteHerrmann marked this pull request as ready for review October 27, 2023 16:10
@MalteHerrmann MalteHerrmann requested a review from a team as a code owner October 27, 2023 16:10
@fedekunze fedekunze merged commit 80e5039 into release/v15.0.x Oct 27, 2023
@fedekunze fedekunze deleted the malte/remove-dist-authz-testnet branch October 27, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@0xstepit 0xstepit 0xstepit approved these changes

@Vvaradinov Vvaradinov Awaiting requested review from Vvaradinov Vvaradinov is a code owner automatically assigned from evmos/core-engineering

@facs95 facs95 Awaiting requested review from facs95 facs95 is a code owner automatically assigned from evmos/core-engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MalteHerrmann @fedekunze @0xstepit
0