8000 feat(stride): Stride outpost types and events by Vvaradinov · Pull Request #1914 · evmos/evmos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(stride): Stride outpost types and events #1914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 20, 2023
Merged

feat(stride): Stride outpost types and events #1914

merged 8 commits into from
Oct 20, 2023

Conversation

Vvaradinov
Copy link
Contributor

Description

Closes ENG-2216

@Vvaradinov Vvaradinov requested a review from a team as a code owner October 19, 2023 11:34
@Vvaradinov Vvaradinov requested review from MalteHerrmann and GAtom22 and removed request for a team October 19, 2023 11:34
@linear
Copy link
linear bot commented Oct 19, 2023

ENG-2216 👨‍💻 Implement types + events + errors + unit tests for

fedekunze
fedekunze reviewed Oct 19, 2023
View reviewed changes
Copy link
Collaborator
@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, minor comments

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 19, 2023
View reviewed changes
precompiles/outposts/stride/events.go
Address: p.Address(),
Topics: topics,
Data: packed,
BlockNumber: uint64(ctx.BlockHeight()),

Check failure

Code scanning / gosec

Potential integer overflow by integer type conversion

Potential integer overflow by integer type conversion
precompiles/outposts/stride/events.go
Address: p.Address(),
Topics: topics,
Data: packed,
BlockNumber: uint64(ctx.BlockHeight()),

Check failure

Code scanning / gosec

Potential integer overflow by integer type conversion

Potential integer overflow by integer type conversion
< 8000 /details>
@codecov
Copy link
codecov bot commented Oct 19, 2023 •
edited
Loading

Codecov Report

Merging #1914 (8fee2ee) into main (6201def) will decrease coverage by 0.51%.
The diff coverage is 11.66%.

❗ Current head 8fee2ee differs from pull request most recent head e632fe8. Consider uploading reports for the commit e632fe8 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1914      +/-   ##
==========================================
- Coverage   70.30%   69.80%   -0.51%     
==========================================
  Files         319      323       +4     
  Lines       23574    23764     +190     
==========================================
+ Hits        16574    16588      +14     
- Misses       6179     6354     +175     
- Partials      821      822       +1
Files Coverage Δ
precompiles/common/types.go 44.68% <0.00%> (-17.09%) ⬇️
precompiles/outposts/stride/types.go 31.11% <31.11%> (ø)
precompiles/outposts/stride/events.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

GAtom22
GAtom22 approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor
@GAtom22 GAtom22 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work @Vvaradinov !! Left a few comments

Please address the gosec warnings

0xstepit
0xstepit approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor
@0xstepit 0xstepit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @Vvaradinov! Left just minor comments

0xstepit
0xstepit reviewed Oct 20, 2023
View reviewed changes
@fedekunze fedekunze enabled auto-merge (squash) October 20, 2023 08:25
@fedekunze fedekunze merged commit f1ecc37 into main Oct 20, 2023
@fedekunze fedekunze deleted the Vvaradinov/stride-outpost-types branch October 20, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xstepit 0xstepit 0xstepit approved these changes

@fedekunze fedekunze fedekunze approved these changes

@GAtom22 GAtom22 GAtom22 approved these changes

@MalteHerrmann MalteHerrmann Awaiting requested review from MalteHerrmann MalteHerrmann is a code owner automatically assigned from evmos/core-engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Vvaradinov @fedekunze @0xstepit @GAtom22
0