8000 chore: ibc denom trace function by 0xstepit · Pull Request #2010 · evmos/evmos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: ibc denom trace function #2010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 7, 2023
Merged

chore: ibc denom trace function #2010

merged 4 commits into from
Nov 7, 2023

Conversation

0xstepit
Copy link
Contributor
@0xstepit 0xstepit commented Nov 7, 2023

Description

This PR adds a function to the utils/utils package for creating the denomination trace of an IBC token. This function simplifies the code when you need to create an IBC denom trace.


Closes #XXX

@0xstepit 0xstepit requested a review from a team as a code owner November 7, 2023 13:14
@0xstepit 0xstepit requested review from Vvaradinov and GAtom22 and removed request for a team November 7, 2023 13:14
Copy link
codecov bot commented Nov 7, 2023

Codecov Report

Merging #2010 (b45ecfa) into main (7c421c0) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2010      +/-   ##
==========================================
- Coverage   69.83%   69.83%   -0.01%     
==========================================
  Files         334      334              
  Lines       24830    24832       +2     
==========================================
  Hits        17341    17341              
- Misses       6593     6595       +2     
  Partials      896      896              
Files Coverage Δ
utils/utils.go 55.07% <0.00%> (-1.65%) ⬇️

Copy link
Contributor
@MalteHerrmann MalteHerrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator
@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above

@0xstepit 0xstepit merged commit f99e06b into main Nov 7, 2023
@0xstepit 0xstepit deleted the stepit/ibc-utils branch November 7, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0