8000 chore(bech32): Port bech32 extension by Vvaradinov · Pull Request #2038 · evmos/evmos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore(bech32): Port bech32 extension #2038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 15, 2023
Merged

chore(bech32): Port bech32 extension #2038

merged 11 commits into from
Nov 15, 2023

Conversation

Vvaradinov
Copy link
Contributor

Description

This PR ports the bech32 precompile over and initializes it, adding it to our AvailableEVMExtensions. Test coverage for the precompile is >90%.

Closes #XXX

@Vvaradinov Vvaradinov requested a review from a team as a code owner November 14, 2023 10:07
@Vvaradinov Vvaradinov requested review from facs95 and 0xstepit and removed request for a team November 14, 2023 10:07
VictorTrustyDev
VictorTrustyDev reviewed Nov 14, 2023
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 14, 2023
View reviewed changes
precompiles/bech32/methods.go
HexToBech32Method = "hexToBech32"
// Bech32ToHexMethod defines the ABI method name to convert a bech32
// formatted address string to an EIP-55 address.
Bech32ToHexMethod = "bech32ToHex"

Check warning

Code scanning / CodeQL

Directly using the bech32 constants

Directly using the bech32 constants instead of the configuration values
precompiles/bech32/bech32.go
switch method.Name {
8000 case HexToBech32Method:
bz, err = p.HexToBech32(method, args)
case Bech32ToHexMethod:

Check warning

Code scanning / CodeQL

Directly using the bech32 constants

Directly using the bech32 constants instead of the configuration values
@0xstepit
Copy link
Contributor

Please add the CHANGELOG entry

fedekunze
fedekunze reviewed Nov 14, 2023
View reviewed changes
Copy link
Collaborator
@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments re setup and license

0xstepit
0xstepit reviewed Nov 14, 2023
View reviewed changes
0xstepit
0xstepit reviewed Nov 14, 2023
View reviewed changes
0xstepit
0xstepit reviewed Nov 14, 2023
View reviewed changes
0xstepit
0xstepit reviewed Nov 14, 2023
View reviewed changes
0xstepit
0xstepit reviewed Nov 14, 2023
View reviewed changes
0xstepit
0xstepit approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor
@0xstepit 0xstepit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @Vvaradinov !

@Vvaradinov Vvaradinov enabled auto-merge (squash) November 14, 2023 15:44
@fedekunze fedekunze disabled auto-merge November 15, 2023 07:05
@fedekunze
Copy link
Collaborator

merging as the error seems unrelated

@fedekunze fedekunze merged commit 2d66645 into main Nov 15, 2023
@fedekunze fedekunze deleted the Vvaradinov/port-bech32-precompile branch November 15, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VictorTrustyDev VictorTrustyDev VictorTrustyDev left review comments

@fedekunze fedekunze fedekunze approved these changes

@0xstepit 0xstepit 0xstepit approved these changes

@facs95 facs95 Awaiting requested review from facs95 facs95 is a code owner automatically assigned from evmos/core-engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Vvaradinov @0xstepit @fedekunze @VictorTrustyDev
0