impr(vesting): refactor x/vesting module
#281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-385 Eth Vesting Account with Clawback
Ref: Cosmos-SDK and Agoric |
Codecov Report
@@ Coverage Diff @@
## main #281 +/- ##
==========================================
+ Coverage 59.64% 64.81% +5.16%
==========================================
Files 96 93 -3
Lines 6374 6159 -215
==========================================
+ Hits 3802 3992 +190
+ Misses 2424 2011 -413
- Partials 148 156 +8
|
…nto ENG-385-refactor-vesting
fedekunze
reviewed
Feb 22, 2022
x/vesting module
fedekunze
added a commit
that referenced
this pull request
Feb 28, 2022
* fix: spelling (#254) * bug (erc20): Compile built-in contracts in the build process (#246) * wip * use the raw value for json (#253) * use the raw value for json * use the raw value for json * check if solc and jq is installed * feat(erc20): wip iterate over contracts * feat(erc20): iterate over contracts * feat(erc20): add ERC20Burnable contract * feat(erc20): lint Makefile * feat(erc20): move contracts dir Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Prajjwol Gautam <prajjwol@gmail.com> * build(deps): bump github.com/cosmos/ibc-go/v3 (#257) * build(deps): bump github.com/cosmos/cosmos-sdk from 0.45.0 to 0.45.1 (#258) Bumps [github.com/cosmos/cosmos-sdk](https://github.com/cosmos/cosmos-sdk) from 0.45.0 to 0.45.1. - [Release notes](https://github.com/cosmos/cosmos-sdk/releases) - [Changelog](https://github.com/cosmos/cosmos-sdk/blob/v0.45.1/CHANGELOG.md) - [Commits](cosmos/cosmos-sdk@v0.45.0...v0.45.1) --- updated-dependencies: - dependency-name: github.com/cosmos/cosmos-sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(inflation): update `bondingIncentive` automatically (#252) * feat(inflation): update bondedRatio automically and bTarget and maxVariance as params * feat(inflation): update comments * feat(inflation): rename b_target to bonding_target * feat(inflation): set maxVariance to zero at genesis * feat(inflation): fix test * feat(inflation): don"t store bondedRatio in store * feat(inflation): fix unit tests Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * `x/incentives`: integration tests (#256) * wip * tests(incentives): add test setup * tests(inflation): wip * tests(inflation): wip * wip * integration(incentives): setup integration test suite * integration(incentives): wip debugging distribution * integration(incentives): fix integration tests distribution * integration(incentives): remove old integration test folder * integration(incentives): add check for incentiveProposal if contract exists at address * remove ethermint replace mod * ENG 477 Integration Tests - `x/inflation` (#259) * wip * tests(incentives): add test setup * tests(inflation): wip * tests(inflation): wip * wip * wip * feat(inflation): add integration tests * feat(inflation): lint * feat(inflation): remove local ethermint dependency * test if github ci pipeline fails with failing integration tests * integration(inflation): Add community pool test * integration(inflation): fix import * integration(inflation): fix import * build(deps): bump github.com/onsi/gomega from 1.17.0 to 1.18.1 (#261) Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.17.0 to 1.18.1. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.17.0...v1.18.1) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ENG 470 inflation module spec (#263) * spec(inflation): fixes from writing the spec * spec(inflation): import md * spec(inflation): refactor * spec(inflation): fix lint * spec(evmos): fix module list (#264) * spec: claims module (#255) * claims: spec * hooks and concepts * spec client * swagger * events * address comments from review * decay period update * fix * epoch: unit tests (#265) * tests(epochs): add types tests * tests(epochs): refactor epoch hook interface * tests(epochs): tidy * tests(epochs): remove unused handler * tests(epochs): remove unused cli test * tests(epochs): delete simulation file * tests(epochs): add keeper grpc tests * tests(epochs): remove unused comment * docs: grpc gateway docs (#266) * feat: ibc transfer claims middleware (#199) * claims module * update * fixes * actions * hook * app setup * params * rm spec * claim fixes * gRPC fixes * fix lint * proto-lint * tests * feat: ibc transfer hook middleware * update version logic * fixes * cleanup ibc module * grpc and genesis * cli' * lint * middleware * app setup * grpc * minor change * test setup * swagger update * claim queries * claim records tests * genesis check * Apply suggestions from code review * remove dup calls * Update x/claim/keeper/ibc_callbacks.go Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * fixes * fix object order on app.go file (#210) * claims: tests (#205) * WIP: finish up claims unit tests * WIP: if action is completed, no rewards * fix more tests * update claim type * WIP: finish up claims unit tests * WIP: if action is completed, no rewards * fix more tests * bookmark * rename default denom * fix moar tests * change the denom * bookmark * comment out the clawback * claim type permission change * PR feedback address * Update x/claim/types/claim_record_test.go Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * ibc callbacks tests (#214) * wip ibc callbacks tests * test fixes * wip test, send and receive ibc * OnReceive callback tests * onAck tests * fixes to ibc testing * rm claim * deps: use IBC-go v3 newest commit * fixes (wip) * hook * merge claim records logic * ibc transfer claim * fix out of range * gitignore * comments * ibc fix * claims module ibctesting (#262) * change ibc-go version, fix tests errors * fix claim tests * update tests * wip ack not working * port ibctesting * fix mergeclaim and test * port testutil * replace mint with inflation * delete unnecessary ibctesting files * delete more files * fix claim on ibc-ack * cleanup * lint * claims test * revert changes to ibctesting app * claims hooks tests * ibc callback unittests * validate params test * types params tests * lint Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com> * tests Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Guillermo Paoletti <guillermo.paoletti@gmail.com> Co-authored-by: Prajjwol Gautam <prajjwol@gmail.com> Co-authored-by: Ramiro Carlucho <ramirocarlucho@gmail.com> * build(deps): bump github.com/onsi/ginkgo/v2 from 2.1.1 to 2.1.2 (#269) * bug(erc20): wip fix gas estimation (#267) * bug(erc20): wip fix gas estimation * bug(erc20): fix gas estimation * bug(erc20): rename payload to data * bug(sigverify): fix multisig (#270) Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * deps(ethermint): bump to v0.10.0-beta1 (#272) * danburck/release changelog (#274) * release: v1-alpha1 changelog (#251) * release: v1.0.0-beta1 changelog (#273) * fix: spelling (#254) * bug (erc20): Compile built-in contracts in the build process (#246) * wip * use the raw value for json (#253) * use the raw value for json * use the raw value for json * check if solc and jq is installed * feat(erc20): wip iterate over contracts * feat(erc20): iterate over contracts * feat(erc20): add ERC20Burnable contract * feat(erc20): lint Makefile * feat(erc20): move contracts dir Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Prajjwol Gautam <prajjwol@gmail.com> * build(deps): bump github.com/cosmos/ibc-go/v3 (#257) * build(deps): bump github.com/cosmos/cosmos-sdk from 0.45.0 to 0.45.1 (#258) Bumps [github.com/cosmos/cosmos-sdk](https://github.com/cosmos/cosmos-sdk) from 0.45.0 to 0.45.1. - [Release notes](https://github.com/cosmos/cosmos-sdk/releases) - [Changelog](https://github.com/cosmos/cosmos-sdk/blob/v0.45.1/CHANGELOG.md) - [Commits](cosmos/cosmos-sdk@v0.45.0...v0.45.1) --- updated-dependencies: - dependency-name: github.com/cosmos/cosmos-sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(inflation): update `bondingIncentive` automatically (#252) * feat(inflation): update bondedRatio automically and bTarget and maxVariance as params * feat(inflation): update comments * feat(inflation): rename b_target to bonding_target * feat(inflation): set maxVariance to zero at genesis * feat(inflation): fix test * feat(inflation): don"t store bondedRatio in store * feat(inflation): fix unit tests Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * `x/incentives`: integration tests (#256) * wip * tests(incentives): add test setup * tests(inflation): wip * tests(inflation): wip * wip * integration(incentives): setup integration test suite * integration(incentives): wip debugging distribution * integration(incentives): fix integration tests distribution * integration(incentives): remove old integration test folder * integration(incentives): add check for incentiveProposal if contract exists at address * remove ethermint replace mod * ENG 477 Integration Tests - `x/inflation` (#259) * wip * tests(incentives): add test setup * tests(inflation): wip * tests(inflation): wip * wip * wip * feat(inflation): add integration tests * feat(inflation): lint * feat(inflation): remove local ethermint dependency * test if github ci pipeline fails with failing integration tests * integration(inflation): Add community pool test * integration(inflation): fix import * integration(inflation): fix import * build(deps): bump github.com/onsi/gomega from 1.17.0 to 1.18.1 (#261) Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.17.0 to 1.18.1. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.17.0...v1.18.1) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ENG 470 inflation module spec (#263) * spec(inflation): fixes from writing the spec * spec(inflation): import md * spec(inflation): refactor * spec(inflation): fix lint * spec(evmos): fix module list (#264) * spec: claims module (#255) * claims: spec * hooks and concepts * spec client * swagger * events * address comments from review * decay period update * fix * epoch: unit tests (#265) * tests(epochs): add types tests * tests(epochs): refactor epoch hook interface * tests(epochs): tidy * tests(epochs): remove unused handler * tests(epochs): remove unused cli test * tests(epochs): delete simulation file * tests(epochs): add keeper grpc tests * tests(epochs): remove unused comment * docs: grpc gateway docs (#266) * feat: ibc transfer claims middleware (#199) * claims module * update * fixes * actions * hook * app setup * params * rm spec * claim fixes * gRPC fixes * fix lint * proto-lint * tests * feat: ibc transfer hook middleware * update version logic * fixes * cleanup ibc module * grpc and genesis * cli' * lint * middleware * app setup * grpc * minor change * test setup * swagger update * claim queries * claim records tests * genesis check * Apply suggestions D77B from code review * remove dup calls * Update x/claim/keeper/ibc_callbacks.go Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * fixes * fix object order on app.go file (#210) * claims: tests (#205) * WIP: finish up claims unit tests * WIP: if action is completed, no rewards * fix more tests * update claim type * WIP: finish up claims unit tests * WIP: if action is completed, no rewards * fix more tests * bookmark * rename default denom * fix moar tests * change the denom * bookmark * comment out the clawback * claim type permission change * PR feedback address * Update x/claim/types/claim_record_test.go Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * ibc callbacks tests (#214) * wip ibc callbacks tests * test fixes * wip test, send and receive ibc * OnReceive callback tests * onAck tests * fixes to ibc testing * rm claim * deps: use IBC-go v3 newest commit * fixes (wip) * hook * merge claim records logic * ibc transfer claim * fix out of range * gitignore * comments * ibc fix * claims module ibctesting (#262) * change ibc-go version, fix tests errors * fix claim tests * update tests * wip ack not working * port ibctesting * fix mergeclaim and test * port testutil * replace mint with inflation * delete unnecessary ibctesting files * delete more files * fix claim on ibc-ack * cleanup * lint * claims test * revert changes to ibctesting app * claims hooks tests * ibc callback unittests * validate params test * types params tests * lint Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com> * tests Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Guillermo Paoletti <guillermo.paoletti@gmail.com> Co-authored-by: Prajjwol Gautam <prajjwol@gmail.com> Co-authored-by: Ramiro Carlucho <ramirocarlucho@gmail.com> * build(deps): bump github.com/onsi/ginkgo/v2 from 2.1.1 to 2.1.2 (#269) * bug(erc20): wip fix gas estimation (#267) * bug(erc20): wip fix gas estimation * bug(erc20): fix gas estimation * bug(erc20): rename payload to data * bug(sigverify): fix multisig (#270) Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * deps(ethermint): bump to v0.10.0-beta1 (#272) * add changelog Co-authored-by: Rajiv Patel-O'Connor <rajiv.patel.oconnor@gmail.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Prajjwol Gautam <prajjwol@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Guillermo Paoletti <guillermo.paoletti@gmail.com> Co-authored-by: Ramiro Carlucho <ramirocarlucho@gmail.com> Co-authored-by: Prajjwol Gautam <not@acyb.org> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Rajiv Patel-O'Connor <rajiv.patel.oconnor@gmail.com> Co-authored-by: Prajjwol Gautam <prajjwol@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Guillermo Paoletti <guillermo.paoletti@gmail.com> Co-authored-by: Ramiro Carlucho <ramirocarlucho@gmail.com> Co-authored-by: Prajjwol Gautam <not@acyb.org> * build(deps): bump github.com/onsi/ginkgo/v2 from 2.1.2 to 2.1.3 (#275) Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.1.2 to 2.1.3. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.1.2...v2.1.3) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * tests: add sigverify tests (#277) * test: sigverify nits (#278) * deps: bump IBC v3 rc0 (#279) * feat(vesting): Add BDD tests and `ClawbackVestingAccount` by Agoric (#268) * integrationTests(Vesting): add vesting tests under icentives module \ * integrationTests(Vesting): add vesting tests for transfer * integrationTests(Vesting): correct spelling * integrationTests(Vesting): update comment * integrationTests(Vesting): get locked and spendable coins from store * integrationTests(Vesting): move testing files to new module folder (still with incentives deps) and add Ethereum tx tests * integrationTests(Vesting): refactor test structure * integrationTests(Vesting): refactor wording * integrationTests(Vesting): split cliff and lock cases * integrationTests(Vesting): split cliff and lock cases * merge main and add todos * feat(vesting): copy files and make proto * feat(vesting): implement custom staking logic and move keeper functions from types to keeper * feat(vesting): replace keeper types import * feat(vesting): remove duplicate sdk proto and types * feat(vesting): fix lint and codec * feat(vesting): refactor vesting tests to use clawback vesting accounts * feat(vesting): add lockup tests * feat(vesting): add governance tests * feat(vesting): comment out tests * feat(vesting): delete vesting calculator * fix IBC test * rm exported Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com> * ibctesting: use `EthAccounts` for IBC tests (#280) * ibctesting: use EthAccounts for IBC tests * fix lint * impr(vesting): refactor `x/vesting` module (#281) * feat(vesting): refactor types/msg_test * feat(vesting): refactor period tests * feat(vesting): refactor clawback vesting account tests * feat(vesting): remove init account helper * feat(vesting): refactore computeClawback tests to TDD * feat(vesting): wip msg_server_test.go * feat(vesting): add msg server tests with one open TODO * feat(vesting): rename clawback address -> accountAddress * feat(vesting): replace amino codec with cdc in module.go * feat(vesting): fix EthAccount conversion to Baseaccount * feat(vesting): add code analysis of post_reward function * feat(vesting): remove post reward logic * feat(vesting): remove unsused interface methods * feat(vesting): fix nil dereference lint * feat(vesting): fix unchecked assertion lint * feat(vesting): remove AllowWithdrawAddr hook * feat(vesting): address PR comments * feat(vesting): remove unvested slashing logic from addGrant * feat(vesting): add CreateVesitngAccountCmd to cli * feat(vesting): add types/utils test * fix gosec Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com> * fix(vesting): call correct staking hooks (#285) * fix(vesting): call correct staking hooks * fix(vesting): refactor stakinghooks interface * docs: testnet fixes (#288) * Update faucet.md * Update join.md * docs: update testnet docs (#289) * feat(vesting): ENG-385 add ante decorators (#286) * add eth ante * merge main * wip * simplify test * refactor integration ante test * fix lint * remove comments * add EthVestingTransactionDecorator description` * add CHANGELOG * vesting: delegation and gov ante handler (#287) * feat(vesting): refactor types/msg_test * feat(vesting): refactor period tests * feat(vesting): refactor clawback vesting account tests * feat(vesting): remove init account helper * feat(vesting): refactore computeClawback tests to TDD * feat(vesting): wip msg_server_test.go * feat(vesting): add msg server tests with one open TODO * feat(vesting): rename clawback address -> accountAddress * feat(vesting): replace amino codec with cdc in module.go * vesting delegation first approach * integration tests * fix delegation vesting * governance ante decorator * test gov vote and cleanup * delete re-added lines Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com> * integration(vesting):refactor perform ethTx into separate function * cleanup ante folder * fix lint * errors and comments * address some comments * remove governance ante decorator * replace ethante with new Handler options on evmos * refactor ante vesting errors Co-authored-by: Ramiro Carlucho <ramirocarlucho@gmail.com> * Update config.go * build(deps): bump golangci/golangci-lint-action from 2.5.2 to 3 (#290) Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 2.5.2 to 3. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@v2.5.2...v3) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * deps: ethermint upgrade to v0.10.0 (#293) * Update disk_optimization.md (#294) * feat(vesting): grpc queries locked, unvested, vested (#291) * wip vesting queries * wip add queries * add grpc query tests * fix lint * feat(vesting): add LockedOnly method * feat(vesting): refactor queries * fix indentation * feat(vesting): adress comments * bug(inflation): multiply daily epoch mint provision calculation by Power reduction (#295) * bug(inflation): multiply daily epoch mint provision calculation by Power reduction * bug(inflation): fix tests * bug(inflation): fix comment * bug(inflation): use sdk.DefaultPowerReduction * bug(inflation): fix genesis tests * vesting: refactor vesting query (#297) * wip * bug(vesting): Refactor UnvestedOnly logic * bug(vesting): clean PR from unrelated changes * bug(vesting): delete unused genesis proto * bug(vesting): refactor comments * Update x/vesting/types/clawback_vesting_account.go Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * vesting: register gRPC web (#299) * claims: ignore vesting accounts on clawback (#298) * swagger * swagger: add IBC and ethermint (#301) * swagger: add IBC and ethermint * add missing modules * fix inflation * lint * fix tests * ante: add validator min commission decorator (#302) * ante: add validator min commission decorator * changelog * rm decorator * rm decorator eip712 * cmd: add genaccount flags for vesting with clawback (#303) * bug(vesting): add clawback vesting account as add-genaccount evmosd cmd * bug(vesting): add to init.sh * bug(vesting): refactor into switch statement * bug(vesting): remove debugging from init.sh * bug(vesting): update flag description * bug(vesting): fix init.sh total supply * bug(vesting): clean init.sh * bug(vesting): refactor `HasLockedCoins` (#306) * bug(vesting): fail delegation if account is locked * bug(vesting): fix error message * bug(vesting): make locked && vested coins delegatable again * docs: add cd step to join doc (#307) Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Rajiv Patel-O'Connor <rajiv.patel.oconnor@gmail.com> Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com> Co-authored-by: Prajjwol Gautam <prajjwol@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Guillermo Paoletti <guillermo.paoletti@gmail.com> Co-authored-by: Ramiro Carlucho <ramirocarlucho@gmail.com> Co-authored-by: Prajjwol Gautam <not@acyb.org> Co-authored-by: litvinsky <60661362+litvinsky@users.noreply.github.com> Co-authored-by: Joe Schmoe <64335177+jolube@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descrption
This PR refactors the previously implemented
ClawbackVestingAccountPR.TODOs
RegisterLegacyAminoCodecOpen Questions:
Part of ENG-385