bytecode: Implement numeric comparison operators #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds comparison operators for numic operands, these will have distinct opcodes from string comparison operands and avoids verbose type checking code in the vm. Instead, the compiler will perform type checks on operands to ensure that unique opcodes are output depending on the types involved.
Rossiar
commented
Mar 18, 2024
|
firebase-deployment for 15b3576 |
Rossiar
commented
Mar 18, 2024
juliaogris
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
lgtm - just a couple of musings that don't really require any change. Curious to see what @camh- thinks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds comparison operators for numic operands, these will have
distinct opcodes from string comparison operands and avoids
verbose type checking code in the vm. Instead, the compiler
will perform type checks on operands to ensure that unique
opcodes are output depending on the types involved.