start status summarize option #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
format! |
Co-authored-by: Lukas <lupeterm@users.noreply.github.com>
|
format! |
Co-authored-by: Lukas <lupeterm@users.noreply.github.com>
greole
reviewed
Mar 17, 2024
|
!format |
|
format! |
Co-authored-by: Lukas <lupeterm@users.noreply.github.com>
greole
reviewed
Mar 21, 2024
greole
approved these changes
Mar 21, 2024
src/obr/signac_wrapper/operations.py
Outdated
| def group_jobs(self, jobs: list[Job], summarize: int = 0) -> dict[str, list[Job]]: | ||
| """Returns the list of jobs of the given OpenFOAMProject where the last `summarize` levels are grouped together at the corresponding parent view.""" | ||
| grouped = {} | ||
| id_view_map = map_view_folder_to_job_id(os.path.join(self.path, "view")) |
There was a problem hiding this comment.
I think we should pass it as parameter, then we are more flexible.
There was a problem hiding this comment.
Just to be clear, you suggest to pass the path, or the view map?
There was a problem hiding this comment.
Im going to go ahead and assume the former
There was a problem hiding this comment.
no the latter, generate the view map outside of this function and pass the map to group_jobs. Because we might pregenerate the map and use it somewhere else too.
src/obr/signac_wrapper/operations.py
Outdated
| if p_view and p_view not in grouped: | ||
| grouped[p_view] = [] | ||
| view = p_view or id_view_map.get(jobid) | ||
| job.doc["state"]["view"] = view |
There was a problem hiding this comment.
Suggested change
| job.doc["state"]["view"] = view |
I think that should be somewhere else, otherwise it an unexpected side effect and hard to find later.
Co-authored-by: Gregor Olenik <go@hpsim.de>
|
format! |
Co-authored-by: Gregor Olenik <greole@users.noreply.github.com>
greole
reviewed
Aug 6, 2024
|
format! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
--summarizeCLI option forobr status