Add service_name to TransactionContext #1274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1274 +/- ##
==========================================
+ Coverage 92.95% 92.95% +<.01%
==========================================
Files 156 156
Lines 23887 23888 +1
==========================================
+ Hits 22203 22205 +2
+ Misses 1684 1683 -1
Continue to review full report at Codecov.
|
aleksuss
reviewed
Mar 15, 2019
exonum/src/blockchain/transaction.rs
Outdated
| /// Returns id of service that own this transaction. | ||
| pub fn service_id(&self) -> u16 { | ||
| self.service_id | ||
| } | ||
|
|
||
| /// Returns name of service that own this transaction. |
There was a problem hiding this comment.
Suggested change
| /// Returns name of service that own this transaction. | |
| /// Returns a name of the service that own this transaction. |
aleksuss
reviewed
Mar 15, 2019
aleksuss
approved these changes
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Tiny internal improvements to support services with dynamic names.
Definition of Done