Implement ProtobufConvert for fixed byte arrays #1279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1279 +/- ##
==========================================
+ Coverage 92.95% 92.96% +<.01%
==========================================
Files 156 156
Lines 23888 23921 +33
==========================================
+ Hits 22204 22237 +33
Misses 1684 1684
Continue to review full report at Codecov.
|
dvush
reviewed
Mar 20, 2019
exonum/src/proto/mod.rs
Outdated
| } | ||
|
|
||
| fn from_pb(pb: Self::ProtoStruct) -> Result<Self, Error> { | ||
| ensure!(pb.len() == $arr_len, "wrong array size: actual {}, expected {}", pb.len(), $arr_len); |
There was a problem hiding this comment.
I think this line is too long.
| bytes fixed_array_8 = 1; | ||
| bytes fixed_array_16 = 2; | ||
| bytes fixed_array_32 = 3; | ||
| } |
| } | ||
|
|
||
| impl_protobuf_convert_fixed_byte_array! { | ||
| 8, 16, 24, 32, 40, 48, 56, 64, |
There was a problem hiding this comment.
Just curious, why this numbers?
There was a problem hiding this comment.
Most common lengths of arrays ? 🙃
aleksuss
approved these changes
Mar 21, 2019
popzxc
approved these changes
Mar 21, 2019
pavel-mukhanov
approved these changes
Mar 21, 2019
9832
dvush
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
See: https://jira.bf.local/browse/ECR-XYZW
Definition of Done