10000 Create fork from patch. by pavel-mukhanov · Pull Request #1403 · exonum/exonum · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Create fork from patch. #1403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 5, 2019
Merged

Create fork from patch. #1403

merged 2 commits into from
Aug 5, 2019

Conversation

pavel-mukhanov
Copy link
Contributor

Overview

Implement From<Patch> trait for Fork.

Definition of Done

  • There are no TODOs left in the merged code
  • Change is covered by automated tests
  • Benchmark results are attached (if applicable)
  • The coding guidelines are followed
  • Public API has proper documentation
  • Changelog is updated if needed (in case of notable or breaking changes)
  • The continuous integration build passes

aleksuss
aleksuss reviewed Aug 5, 2019
View reviewed changes
aleksuss
aleksuss reviewed Aug 5, 2019
View reviewed changes
@codecov
Copy link
codecov bot commented Aug 5, 2019 •
edited
Loading

Codecov Report

Merging #1403 into master will decrease coverage by 0.01%.
The diff coverage is 96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1403      +/-   ##
==========================================
- Coverage   93.75%   93.74%   -0.02%     
==========================================
  Files         165      165              
  Lines       25777    25810      +33     
==========================================
+ Hits        24168    24196      +28     
- Misses       1609     1614       +5
Impacted Files Coverage Δ
testkit/src/lib.rs 94.32% <100%> (+0.01%) ⬆️
testkit/src/checkpoint_db.rs 94.56% <100%> (+0.01%) ⬆️
exonum/tests/explorer/blockchain/mod.rs 97.89% <100%> (+0.02%) ⬆️
components/merkledb/src/views/tests.rs 93.39% <100%> (+0.28%) ⬆️
exonum/src/node/state.rs 92.83% <100%> (-0.03%) ⬇️
exonum/src/blockchain/mod.rs 89.43% <100%> (+0.25%) ⬆️
exonum/src/node/consensus.rs 89.66% <91.66%> (-0.14%) ⬇️
components/merkledb/src/db.rs 91.81% <91.66%> (-1.2%) ⬇️
components/merkledb/src/proof_map_index/tests.rs 98.35% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 219aa2c...aa1908d. Read the comment docs.

@aleksuss aleksuss merged commit bff552e into exonum:master Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alekseysidorov alekseysidorov alekseysidorov approved these changes

@aleksuss aleksuss aleksuss approved these changes

@popzxc popzxc popzxc approved these changes

@slowli slowli Awaiting requested review from slowli

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pavel-mukhanov @alekseysidorov @aleksuss @popzxc
0