Fix Propose invalidation logic [ECR-4223]
#1782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A `Propose` could be marked as invalid even if it did not contain invalid transactions, simply as a result of processing an invalid transaction.
Codecov Report
@@ Coverage Diff @@
## master #1782 +/- ##
==========================================
- Coverage 94.49% 94.49% -0.01%
==========================================
Files 267 267
Lines 41608 41643 +35
==========================================
+ Hits 39317 39350 +33
- Misses 2291 2293 +2
Continue to review full report at Codecov.
|
aleksuss
approved these changes
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes
Proposeinvalidation logic. AProposecould be marked as invalid even if it did not contain invalid transactions, simply as a result of processing an unrelated invalid transaction.Not done:
See: https://jira.bf.local/browse/ECR-4223