8000 Update Rust idioms some more [ECR-4270] by slowli · Pull Request #1799 · exonum/exonum · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update Rust idioms some more [ECR-4270] #1799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Mar 5, 2020
Merged

Update Rust idioms some more [ECR-4270] #1799

merged 17 commits into from
Mar 5, 2020

Conversation

slowli
Copy link
Contributor
@slowli slowli commented Feb 28, 2020

Overview

This is a follow-up to #1797 that updates other Exonum components.

See: https://jira.bf.local/browse/ECR-4270

@codecov
Copy link
codecov bot commented Feb 28, 2020 •
edited
Loading

Codecov Report

Merging #1799 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1799      +/-   ##
==========================================
+ Coverage   94.80%   94.85%   +0.05%     
==========================================
  Files         269      269              
  Lines       42044    42056      +12     
==========================================
+ Hits        39859    39894      +35     
+ Misses       2185     2162      -23
Impacted Files Coverage Δ
components/system-api/src/private.rs 73.17% <0.00%> (-0.36%) ⬇️
test-suite/testkit/src/network.rs 98.86% <0.00%> (+0.04%) ⬆️
test-suite/testkit/src/api.rs 92.44% <0.00%> (+0.08%) ⬆️
exonum/src/helpers/types.rs 90.66% <0.00%> (+0.12%) ⬆️
exonum-node/src/events/network.rs 88.75% <0.00%> (+0.60%) ⬆️
components/api/src/manager.rs 82.71% <0.00%> (+3.61%) ⬆️
test-suite/testkit/src/server.rs 96.53% <0.00%> (+4.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3438731...38873c3. Read the comment docs.

@slowli slowli merged commit b9f74b2 into exonum:master Mar 5, 2020
@slowli slowli deleted the update-idioms-some-more branch March 5, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alekseysidorov alekseysidorov alekseysidorov approved these changes

@aleksuss aleksuss Awaiting requested review from aleksuss

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slowli @alekseysidorov
0