8000 Report errors in dispatcher more thoroughly [ECR-4245] by slowli · Pull Request #1806 · exonum/exonum · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Report errors in dispatcher more thoroughly [ECR-4245] #1806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 11, 2020
Merged

Report errors in dispatcher more thoroughly [ECR-4245] #1806

merged 6 commits into from
Mar 11, 2020

Conversation

slowli
Copy link
Contributor
@slowli slowli commented Mar 6, 2020

Overview

This PR improves error reporting in dispatcher logic.

See: https://jira.bf.local/browse/ECR-4245

@slowli slowli added breaking change ⚠️ API or ABI is changed. core Changes affecting exonum core labels Mar 6, 2020
@codecov
Copy link
codecov bot commented Mar 6, 2020 •
edited
Loading

Codecov Report

Merging #1806 into master will decrease coverage by 0.04%.
The diff coverage is 80.98%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1806      +/-   ##
==========================================
- Coverage   94.86%   94.82%   -0.05%     
==========================================
  Files         271      271              
  Lines       42207    42295      +88     
==========================================
+ Hits        40041    40106      +65     
- Misses       2166     2189      +23
Impacted Files Coverage Δ
exonum/src/runtime/error/core_errors.rs 85.71% <ø> (ø)
exonum/src/runtime/dispatcher/mod.rs 91.71% <71.79%> (-1.96%) ⬇️
exonum/src/runtime/dispatcher/schema.rs 93.01% <75.60%> (-4.09%) ⬇️
exonum/src/blockchain/tests.rs 94.62% <100.00%> (+0.54%) ⬆️
exonum/src/runtime/dispatcher/migration_tests.rs 97.95% <100.00%> (+0.01%) ⬆️
exonum/src/runtime/dispatcher/tests.rs 90.48% <100.00%> (+0.14%) ⬆️
exonum/src/runtime/execution_context.rs 96.46% <100.00%> (-0.02%) ⬇️
runtimes/rust/tests/async_migration.rs 95.71% <100.00%> (+0.01%) ⬆️
runtimes/rust/tests/basic.rs 95.92% <100.00%> (+<0.01%) ⬆️
runtimes/rust/tests/migration.rs 96.61% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7e093c...1534bce. Read the comment docs.

@aleksuss aleksuss merged commit 79d1b6c into exonum:master Mar 11, 2020
@slowli slowli deleted the dispatcher-errors branch April 1, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alekseysidorov alekseysidorov alekseysidorov approved these changes

@aleksuss aleksuss aleksuss approved these changes

Assignees
No one assigned
Labels
breaking change ⚠️ API or ABI is changed. core Changes affecting exonum core
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slowli @alekseysidorov @aleksuss
0