8000 Extra black screen during sharing · Issue #203 · expo/react-native-action-sheet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Extra black screen during sharing #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
abhi0504 opened this issue Jan 28, 2021 · 9 comments · Fixed by #248
Closed

Extra black screen during sharing #203

abhi0504 opened this issue Jan 28, 2021 · 9 comments · Fixed by #248
Labels
released

Comments

@abhi0504
Copy link

Hi ,
I am one of contributor of Zulip and we are using @expo/react-native-action-sheet in our zulip
/zulip-mobile repo .
One of our member reported an issue here so on working on that we had confirmed that there is a problem in @expo/react-native-action-sheet by making a tiny react app using this library .
In short the problem is that when we long press on a message in our app then a messageActionList is opened and then when we click on Share option then it tooks an extra black screen to share. Detailed explaination of this issue is here Also you can reffer our chat when we try to debug this issue here
@abhi0504
Copy link
Author

I also have make tiny react native app for this issue where this issue can be elaborted easily here is the repo you can just fork this repo and then yarn and then the app is opened
I am also attaching a video below you can also go through it

WhatsApp.Video.2021-01-28.at.3.34.43.PM.mp4

@bradbyte
Copy link
Contributor

Hello @abhi0504, sorry for the delay. Were you able to determine what the issue was with the code? The Android is a custom implementation which would explain why iOS worked fine. Is it possible you could make a snack for this so it's easier to troubleshoot?

@abhi0504
Copy link
Author

Hey @bradbyte I think the issue is when we click on Share then it creates an extra screen or share the message without closing the messageActionSheet instead of this it should first close the messageActionSheet and then implement the Share . Sure I have created a snack here is the link you can have a look

@abhi0504 abhi0504 mentioned this issue Feb 19, 2021
Closed
@kaushil111
Copy link

Facing the same issue 👍

@J-Bossi
Copy link
J-Bossi commented Apr 29, 2021

I'm facing the same issue. Seems to happen with any other modal (Share, camera, etx.), that is presented on top of this actionSheet.
My hacky resolution is that a that i wrap my share action in a short timeout.

@bradbyte
Copy link
Contributor
bradbyte commented Sep 7, 2021

😢 Sorry I never followed up with this -- I am able to replicate this. I'm not sure why the setTimeout works. One possible solution is to wrap the callback internally in a setTimeout so you don't have to, or at the least update the docs so it can help guard against this. @kaushil111 @J-Bossi @abhi0504 were you ever able to figure out anything more on this?

bradbyte pushed a commit that referenced this issue Oct 18, 2021
fix: defer calling onSelect until after animation
b2ca77a 
- Fixes #203
@bradbyte bradbyte mentioned this issue Oct 18, 2021
Merged
@bradbyte
Copy link
Contributor

@kaushil111 @J-Bossi @abhi0504 I pushed up a branch that should fix this. If you have a second, would you care to pull it in and see if it resolves your issue? Thank you!

bradbyte pushed a commit that referenced this issue Oct 19, 2021
fix: defer calling onSelect until after animation (#248)
1fb3411 
- Fixes #203
@kaushil111
Copy link

Awesome! Thanks a lot! Will take a look 👍

github-actions bot pushed a commit that referenced this issue Jan 10, 2022
@semantic-release-bot
chore(release): 3.13.0 [skip ci]
9ea2d08 
# [3.13.0](v3.12.0...v3.13.0) (2022-01-10)

### Bug Fixes

* defer calling onSelect until after animation ([#248](#248)) ([1fb3411](1fb3411)), closes [#203](#203)
* stabilize the identity of the context provider value ([#251](#251)) ([55005ba](55005ba))

### Features

* support closing actionsheet with Esc key on web ([#247](#247)) ([c4c3f8b](c4c3f8b)), closes [#194](#194)
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 3.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@bradbyte bradbyte mentioned this issue Jan 10, 2022
Closed
@gnprice gnprice mentioned this issue Mar 21, 2022
Closed
robertomartinez09515 added a commit to robertomartinez09515/action-sheet-react-best-proj that referenced this issue Jul 25, 2022
@robertomartinez09515
chore(release): 3.13.0 [skip ci]
5a8c12c 
# [3.13.0](expo/react-native-action-sheet@v3.12.0...v3.13.0) (2022-01-10)

### Bug Fixes

* defer calling onSelect until after animation ([#248](expo/react-native-action-sheet#248)) ([1fb3411](expo/react-native-action-sheet@1fb3411)), closes [#203](expo/react-native-action-sheet#203)
* stabilize the identity of the context provider value ([#251](expo/react-native-action-sheet#251)) ([55005ba](expo/react-native-action-sheet@55005ba))

### Features

* support closing actionsheet with Esc key on web ([#247](expo/react-native-action-sheet#247)) ([c4c3f8b](expo/react-native-action-sheet@c4c3f8b)), closes [#194](expo/react-native-action-sheet#194)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: defer calling onSelect until after animation expo/react-native-action-sheet
4 participants
@J-Bossi @kaushil111 @bradbyte @abhi0504
0