8000 feat(server): suggest time unit in errors by ezyang · Pull Request #152 · ezyang/scubaduck · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(server): suggest time unit in errors #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2025
Merged

feat(server): suggest time unit in errors #152

merged 1 commit into from
May 23, 2025

Conversation

ezyang
Copy link
Owner
@ezyang ezyang commented May 23, 2025

Summary

  • guess appropriate time unit when numeric timestamps cannot be parsed
  • surface suggestion in error response
  • test hinting of time unit

Testing

  • ruff check scubaduck/server.py tests/test_server_errors.py
  • pyright scubaduck/server.py tests/test_server_errors.py
  • pytest -q tests/test_server_errors.py::test_invalid_integer_time_value_suggests_unit
  • pytest -q

@ezyang ezyang added the codex label May 23, 2025 — with ChatGPT Connector
@ezyang ezyang merged commit b2bd0b9 into main May 23, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
codex
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ezyang
0