8000 Fix typo in getting started C++ section by juanjo4936 · Pull Request #1002 · eProsima/Fast-DDS-docs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix typo in getting started C++ section #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 24, 2024
Merged

Fix typo in getting started C++ section #1002

merged 2 commits into from
Dec 24, 2024

Conversation

juanjo4936
Copy link
Contributor
@juanjo4936 juanjo4936 commented Dec 24, 2024 •
edited
Loading

Description

This PR deletes the section 1.3.6.1 in FastDDS, which was made unnecessary after an update on the CMakeLists.txt and referred to the wrong code afterwards.

@Mergifyio backport 3.1.x 3.0.x 2.14.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

Hotfix: deleted a section that is no longer needed
9a6ad37 
Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
@juanjo4936 juanjo4936 added this to the v3.2.0 milestone Dec 24, 2024
@juanjo4936 juanjo4936 self-assigned this Dec 24, 2024
@juanjo4936 juanjo4936 removed the request for review from richiprosima December 24, 2024 10:33
Hotfix: solved the failure of the CI
8407fd1 
Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
@juanjo4936 juanjo4936 requested review from richiprosima and removed request for richiprosima December 24, 2024 11:55
juanlofer-eprosima
juanlofer-eprosima approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor
@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juanjo4936 juanjo4936 changed the title Hotfix: deleted a section that is no longer needed in 1.3 Hotfix: deleted a section in 1.3 Dec 24, 2024
@juanjo4936 juanjo4936 changed the title Hotfix: deleted a section in 1.3 Deleted a section in 1.3 Dec 24, 2024
@juanjo4936 juanjo4936 changed the title Deleted a section in 1.3 Fix typo in getting started C++ section Dec 24, 2024
@juanlofer-eprosima juanlofer-eprosima merged commit 5815f2d into master Dec 24, 2024
4 checks passed
@juanlofer-eprosima juanlofer-eprosima deleted the hotfix/DDSHelloWorld branch December 24, 2024 13:23
@juanjo4936
Copy link
Contributor Author

@Mergifyio backport 3.1.x 3.0.x 2.14.x

@mergify Mergify
Copy link
mergify bot commented Dec 24, 2024 •
edited
Loading

backport 3.1.x 3.0.x 2.14.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 24, 2024
@juanjo4936 @mergify
Fix typo in getting started C++ section (#1002)
d4aea3c 
* Hotfix: deleted a section that is no longer needed

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Hotfix: solved the failure of the CI

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

---------

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
(cherry picked from commit 5815f2d)
mergify bot pushed a commit that referenced this pull request Dec 24, 2024
@juanjo4936 @mergify
Fix typo in getting started C++ section (#1002)
9726680 
* Hotfix: deleted a section that is no longer needed

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Hotfix: solved the failure of the CI

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

---------

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
(cherry picked from commit 5815f2d)
This was referenced Dec 24, 2024
Merged
Merged
mergify bot pushed a commit that referenced this pull request Dec 24, 2024
@juanjo4936 @mergify
Fix typo in getting started C++ section (#1002)
1a9766e 
* Hotfix: deleted a section that is no longer needed

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Hotfix: solved the failure of the CI

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

---------

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
(cherry picked from commit 5815f2d)

# Conflicts:
#	docs/fastdds/getting_started/simple_app/includes/dataType.rst
@mergify mergify bot mentioned this pull request Dec 24, 2024
Merged
7 tasks
juanlofer-eprosima pushed a commit that referenced this pull request Dec 24, 2024
@mergify @juanjo4936
Fix typo in getting started C++ section (#1002) (#1004)
e4597c0 
* Hotfix: deleted a section that is no longer needed

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Hotfix: solved the failure of the CI

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

---------

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
(cherry picked from commit 5815f2d)

Co-authored-by: juanjo4936 <69901369+juanjo4936@users.noreply.github.com>
juanlofer-eprosima pushed a commit that referenced this pull request Dec 24, 2024
@mergify @juanjo4936
Fix typo in getting started C++ section (#1002) (#1005)
733573d 
* Hotfix: deleted a section that is no longer needed

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Hotfix: solved the failure of the CI

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

---------

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
(cherry picked from commit 5815f2d)

Co-authored-by: juanjo4936 <69901369+juanjo4936@users.noreply.github.com>
juanlofer-eprosima pushed a commit that referenced this pull request Dec 24, 2024
@mergify @juanjo4936
Fix typo in getting started C++ section (backport #1002) (#1006)
f702b0b 
* Fix typo in getting started C++ section (#1002)

* Hotfix: deleted a section that is no longer needed

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Hotfix: solved the failure of the CI

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

---------

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
(cherry picked from commit 5815f2d)

# Conflicts:
#	docs/fastdds/getting_started/simple_app/includes/dataType.rst

* Hotfix: Solved the conflict

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

---------

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
Co-authored-by: juanjo4936 <69901369+juanjo4936@users.noreply.github.com>
Co-authored-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanlofer-eprosima juanlofer-eprosima juanlofer-eprosima approved these changes

Assignees

@juanjo4936 juanjo4936

Labels
ci-pending
Projects
None yet
Milestone
v3.2.0 - Frozen ❄️
Development

Successfully merging this pull request may close these issues.
2 participants
@juanjo4936 @juanlofer-eprosima
0