Tags: easyops-cn/zipkin-go
Tags
Fix HTTP reporter potential unbounded goroutine creation (openzipkin#146 ) * Fix HTTP reporter potential unbounded goroutine creation Currently the HTTP reporter spawns a new goroutine each time a new batch needs to be sent to the server. Execution of those goroutines gets serialized through the `sendMtx`. This behavior is problematic when the zipkin server is down and leads to creation of unbounded number of goroutines each of which will wait for its turn on the `sendMtx` and then fail. Fix this by creating one send goroutine to handle sending data to the server. This also removes the need for the `sendMtx` since `sendBatch` will only be called by the send goroutine. Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com> * Add more HTTP reporter test cases Add HTTP reporter test cases for BatchInterval() and BatchSize() options behavior. Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com>
Merge pull request openzipkin#133 from openzipkin/128_request_sampler… …_for_client feat(openzipkin#128): adds support for request sampler in client.
Merge pull request openzipkin#133 from openzipkin/128_request_sampler… …_for_client feat(openzipkin#128): adds support for request sampler in client.
Merge pull request openzipkin#115 from dmitshur/update-grpc go.mod: update grpc from v1.16.0 to v1.17.0
Merge pull request openzipkin#103 from anuraaga/grpc-readme Update README for gRPC.
proto: add Zipkin proto + converter (openzipkin#88) * proto: add Zipkin proto + converter Added: a) Zipkin v2 Proto3 definitions from https://github.com/openzipkin/zipkin-api/blob/6dfa27520abb62de7b01dba04683177afaa40c8c/zipkin.proto b) a helper Protobuf function ParseSpans to parse model.SpanModel-s from the serialized protobuf data as well as an end-to-end test. Fixes openzipkin#87 Spawned by census-instrumentation/opencensus-service#155 * proto/*/convert_proto.go: rename zps to s, return err early Addressing review feedback: * Rename zps to s * On encountering any error during protoSpan->zipkinModelSapn, return ASAP * proto/*/v2: move payload to a global variable Requested in codereview feedback * proto/*/v2: make fmt.Errorf calls more descriptive Provide a more descriptive context in fmt.Errorf calls to match the style in: https://github.com/openzipkin/zipkin-go/blob/master/propagation/b3/shared.go * proto/*/v2: test and assert known failures Test to ensure that the failures that we know could happen e.g. * Missing/invalid length TraceID * Missing/invalid length SpanID * Invalid length ParentSpanID are caught and report errors instead of successfully parsing. Also tweaked the errors returned to be more descriptive and graceful.
Merge pull request openzipkin#82 from openzipkin/80_removes_response_… …size_on_empty fix(openzipkin#80): removes http.response.size when response body is empty.
Merge pull request openzipkin#61 from basvanbeek/master middleware: Improved http.Handler logic and added RequestSampler option
PreviousNext