-
Notifications
You must be signed in to change notification settings - Fork 418
Allow user to override container and volume names #1083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ba22b2b
to
9623bc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - @dchw might want to look at this too.
Another possible issue: clashing port numbers. You might want to try to run multiple local buildkits and see if everything works correctly. Possible issues: debugger, TCP connectivity, export via local registry. Might be worth testing out these features to make sure they work as expected.
unfortunately that did happen with the interactive debugger. I'll see if I can override it and use a random port if it's already in use. |
9623bc9
to
c41f149
Compare
I had quick go to see if we could have the OS assign us a random free port, but it's non-trivial and will take some effort. Do we want to address this in a follow up PR? The benefit is we make use of switching volumes which means we can reset one cache for testing without having it affect build times while compiling earthly. |
This allows a user to switch between volume caches, which increases the speed of testing operations where one needs to reset the volume cache. Signed-off-by: Alex Couture-Beil <alex@earthly.dev>
c41f149
to
3ab63d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
Another possibility could be to define a port range to use for the debugger, local registry etc. Something like |
This allows a user to switch between volume caches, which increases the
speed of testing operations where one needs to reset the volume cache.
Signed-off-by: Alex Couture-Beil alex@earthly.dev