10000 Allow user to override container and volume names by alexcb · Pull Request #1083 · earthly/earthly · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Allow user to override container and volume names #1083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2021
Merged

Conversation

alexcb
Copy link
Contributor
@alexcb alexcb commented Jul 6, 2021

This allows a user to switch between volume caches, which increases the
speed of testing operations where one needs to reset the volume cache.

Signed-off-by: Alex Couture-Beil alex@earthly.dev

@alexcb alexcb force-pushed the change-volume-name branch from ba22b2b to 9623bc9 Compare July 6, 2021 00:17
@alexcb alexcb requested review from vladaionescu and dchw July 6, 2021 16:27
Copy link
Member
@vladaionescu vladaionescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - @dchw might want to look at this too.

Another possible issue: clashing port numbers. You might want to try to run multiple local buildkits and see if everything works correctly. Possible issues: debugger, TCP connectivity, export via local registry. Might be worth testing out these features to make sure they work as expected.

@alexcb
Copy link
Contributor Author
alexcb commented Jul 6, 2021

clashing port numbers

unfortunately that did happen with the interactive debugger. I'll see if I can override it and use a random port if it's already in use.

@alexcb alexcb force-pushed the change-volume-name branch from 9623bc9 to c41f149 Compare July 7, 2021 00:03
@alexcb
Copy link
Contributor Author
alexcb commented Jul 7, 2021

I had quick go to see if we could have the OS assign us a random free port, but it's non-trivial and will take some effort. Do we want to address this in a follow up PR? The benefit is we make use of switching volumes which means we can reset one cache for testing without having it affect build times while compiling earthly.

This allows a user to switch between volume caches, which increases the
speed of testing operations where one needs to reset the volume cache.

Signed-off-by: Alex Couture-Beil <alex@earthly.dev>
@alexcb alexcb force-pushed the change-volume-name branch from c41f149 to 3ab63d5 Compare July 7, 2021 18:01
@alexcb alexcb requested a review from vladaionescu July 7, 2021 23:54
Copy link
Member
@vladaionescu vladaionescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@vladaionescu
Copy link
Member

Another possibility could be to define a port range to use for the debugger, local registry etc. Something like 1230-1239. Though I agree that random port seems best if it's possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0