8000 elements.util.ExecutorsUtil : Ignoring error · Issue #2330 · eclipse-californium/californium · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

elements.util.ExecutorsUtil : Ignoring error #2330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fitch2015 opened this issue Mar 1, 2025 · 8 comments
Open

elements.util.ExecutorsUtil : Ignoring error #2330

fitch2015 opened this issue Mar 1, 2025 · 8 comments
Labels
bug retest - validate PR

Comments

@fitch2015
Copy link

When using version 4.0.0-M3, the following warning logs have appeared, which did not seem to occur in previous versions. Not sure if this has any impact. Thank you.

2025-03-01 19:35:33.686 WARN 9682 --- [0.0.0.0:32904#0] o.e.c.elements.util.ExecutorsUtil : Ignoring error:
java.lang.NullPointerException: null
at org.eclipse.californium.scandium.dtls.InMemoryConnectionStore.lambda$addToAddressConnections$1(InMemoryConnectionStore.java:633)
at org.eclipse.californium.elements.util.ExecutorsUtil.runAll(ExecutorsUtil.java:271)
at org.eclipse.californium.scandium.dtls.Connection.shutdown(Connection.java:311)
at org.eclipse.californium.scandium.dtls.InMemoryConnectionStore.remove(InMemoryConnectionStore.java:559)
at org.eclipse.californium.scandium.DTLSConnector$2.handshakeFailed(DTLSConnector.java:716)
at org.eclipse.californium.scandium.dtls.Handshaker.failHandshake(Handshaker.java:2326)
at org.eclipse.californium.scandium.dtls.Handshaker.handshakeFailed(Handshaker.java:2257)
at org.eclipse.californium.scandium.DTLSConnector.lambda$getConnectionForNewClientHello$7(DTLSConnector.java:2490)
at org.eclipse.californium.elements.util.SerialExecutor.run(SerialExecutor.java:323)
at org.eclipse.californium.elements.util.SerialExecutor.lambda$scheduleNextJob$0(SerialExecutor.java:300)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:750)
@boaks
Copy link
Contributor
boaks commented Mar 2, 2025

Thanks!

I guess

previous.getEstablishedSessionIdentifier().isEmpty()

is causing that. I will fix it tomorrow.

@boaks boaks added the bug label Mar 2, 2025
boaks added a commit to boaks/californium that referenced this issue Mar 3, 2025
@boaks
InMemoryConnectionStore: fix NullPointerException.
796ebdc 
Fixes issue eclipse-californium#2330

Signed-off-by: Achim Kraus <achim.kraus@cloudcoap.net>
@boaks boaks mentioned this issue Mar 3, 2025
Merged
@boaks
Copy link
Contributor
boaks commented Mar 3, 2025

PR #2331 contains the fix. Please retest, if possible.

boaks added a commit to boaks/californium that referenced this issue Mar 6, 2025
@boaks
InMemoryConnectionStore: fix NullPointerException.
2931944 
Fixes issue eclipse-californium#2330

Signed-off-by: Achim Kraus <achim.kraus@cloudcoap.net>
@fitch2015
Copy link
Author

After testing, the issue has been successfully resolved. Thanks.

@boaks
Copy link
Contributor
boaks commented Mar 10, 2025

Thanks for the feedback.
I would like to add some unit-tests before merging it.

Do you need a 4.0.0-M4 "soon"? Is it OK to fix it with the next?

(My current plan is to remove handshake probe and the key management (remove frequently copy&destroy). )

@fitch2015
Copy link
Author
fitch2015 commented Mar 11, 2025 via email •
edited
Loading

@boaks
Copy link
Contributor
boaks commented Mar 11, 2025

If possible, please release a version first.

I will do so.

the quick reconnection process

Interesting. I'm used to relax the times during handshake, in my experience that performs better.
What is the purpose of such a quick reconnect (and I guess even quicker than the first has finished)?

@boaks
Copy link
Contributor
boaks commented Mar 11, 2025

Just as additional note:
The exception is caused by the missing established session. But in that case, the pending handshake will already remove the connection before the exception. So the issues is only a irritating logging.
I added a unit test, but though logging itself is not unit tested, the test doesn't fail even with that error.

boaks added a commit to boaks/californium that referenced this issue Mar 11, 2025
@boaks
InMemoryConnectionStore: fix NullPointerException.
d2a4e5c 
A connection without established session is removed by the failing
handshake, so this issue is only about a irritating logging message.

Fixes issue eclipse-californium#2330

Signed-off-by: Achim Kraus <achim.kraus@cloudcoap.net>
@boaks
Copy link
Contributor
boaks commented Mar 11, 2025

After deeper analyze, this happens only:

  • if DTLS 1.2 CID is not used
  • a new handshake is started before the previous is finished

and it's only an irritating logging message.

Therefore I prefer to release this fix with a M4 including more stuff then just this fix.

boaks added a commit that referenced this issue Mar 11, 2025
@boaks
InMemoryConnectionStore: fix NullPointerException.
bcdf56f 
A connection without established session is removed by the failing
handshake, so this issue is only about a irritating logging message.

Fixes issue #2330

Signed-off-by: Achim Kraus <achim.kraus@cloudcoap.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug retest - validate PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fitch2015 @boaks
0